DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=tlPF2Mftf7KdN8oON76fej/QbIC26PAVuZrH6tSzm5RS0u2JeHjx6cYk8zbhccsBAP
         EmR+3YJo8DXSGgV84FfUYiBzGvhKUlEelt4y08yMMugG+YtWTChv5fqhjGP4pLa6LTd7
         BlK4IByxjPKvLVsuOO2ESKDOUlHqQlFrsDCI8=
MIME-Version: 1.0
In-Reply-To: <20110502004940.2307.71738.stgit@ul30vt.home>
References: <20110502004806.2307.34136.stgit@ul30vt.home>
	<20110502004940.2307.71738.stgit@ul30vt.home>
Date: Wed, 4 May 2011 13:50:19 +1000
Message-ID: <BANLkTi==E4wgRDY3DCDejAZtVvOGjOtbgA@mail.gmail.com>
Subject: Re: [PATCH 2/2] drm/nouveau: Check that the device is enabled before
 processing interrupt
From: Dave Airlie <airlied@gmail.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1119
Lines: 26

On Mon, May 2, 2011 at 10:49 AM, Alex Williamson
<alex.williamson@redhat.com> wrote:
> We're likely to be sharing an interrupt line with other devices,
> which means our handler might get called after we've turned off
> the device via vga switcheroo. ?This can lead to all sorts of
> badness, like nv04_fifo_isr() spewing "PFIFO still angry after
> 100 spins, halt" to the console before the system enters a hard
> hang.
>
> We can avoid this by simply checking if the device is still
> enabled before processing an interrupt. ?To avoid races, flush
> any inflight interrupts using synchronize_irq(). ?Note that
> since pci_intx() is called after pci_save_state(),
> pci_restore_state() will automatically re-enable INTx.

I still think we should just need the synchronize_irq followed by a
check in the irq handler for all fs,

or is there a race there I'm missing?

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/