Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752314Ab1EDI2m (ORCPT ); Wed, 4 May 2011 04:28:42 -0400 Received: from merkurneu.hrz.uni-giessen.de ([134.176.2.3]:38897 "EHLO merkurneu.hrz.uni-giessen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752063Ab1EDI2k convert rfc822-to-8bit (ORCPT ); Wed, 4 May 2011 04:28:40 -0400 From: Marc Dietrich To: Wei Ni Subject: Re: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c Date: Wed, 4 May 2011 10:28:07 +0200 User-Agent: KMail/1.13.7 (Linux/2.6.39-rc5+; KDE/4.6.2; x86_64; ; ) Cc: Stephen Warren , "khali@linux-fr.org" , "ben-linux@fluff.org" , "lucas.demarchi@profusion.mobi" , "ccross@android.com" , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "Olof Johansson (olof@lixom.net)" References: <1303301312-15302-1-git-send-email-wni@nvidia.com> <74CDBE0F657A3D45AFBB94109FB122FF0497F1AEEF@HQMAIL01.nvidia.com> <6B4D417B830BC44B8026029FD256F7F1C2CB3DD4E6@HKMAIL01.nvidia.com> In-Reply-To: <6B4D417B830BC44B8026029FD256F7F1C2CB3DD4E6@HKMAIL01.nvidia.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Message-Id: <201105041028.09316.marc.dietrich@ap.physik.uni-giessen.de> X-HRZ-JLUG-MailScanner-Information: Passed JLUG virus check X-HRZ-JLUG-MailScanner: No virus found X-Envelope-From: marc.dietrich@ap.physik.uni-giessen.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3326 Lines: 97 Wei, Stephen, > Hi, Stephen > I think if doesn't need to apply the slave address codes, we can use your > patch. we use the slave address as part of our nvec mfd driver in the ac100 project, so it would be nice to have this merged. Is there any other implemenation for a driver which actually use "is_slave"? (beside the one from the older android kernels)? Regards, Marc > Thanks > Wei. > > -----Original Message----- > From: Stephen Warren > Sent: Friday, April 29, 2011 11:20 PM > To: Wei Ni > Cc: khali@linux-fr.org; ben-linux@fluff.org; lucas.demarchi@profusion.mobi; > ccross@android.com; linux-i2c@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-tegra@vger.kernel.org; Olof Johansson > (olof@lixom.net) Subject: RE: [PATCH 0/2] i2c: tegra: add some new > features for tegra i2c > > Wei Ni wrote at Friday, April 29, 2011 12:08 AM: > > Stephen Warren wrote at Thursday, April 28, 2011 12:29 AM: > > > Wei Ni wrote at Wednesday, April 27, 2011 4:26 AM: > > > > Hi, all > > > > Could anyone review these changes? > > > > > > Wei, > > > > > > It looks like some of the patches I recently posted address the same > > > issues as the patches you had already posted. Sorry for the potential > > > conflicts. > > > > Hi, Stephen > > I think your patches address the different issues with my patches. > > My patches are used for retry transfer and new slave controller. > > Wei, aren't the following two patches basically the same thing, > except that yours also sets the slave address register, and is a bit > more wordy: > > http://www.spinics.net/lists/linux-i2c/msg05464.html > http://www.spinics.net/lists/linux-i2c/msg05437.html > > Upon further inspection, I don't think any of the other patches I > posted conflict with the other patch you posted. > > > > Can you please take a look at the patches I posted and comment on which > > > of those are still relevant given your patches. Even for the cases > > > where we both posted patches to address the same issue (e.g. use new > > > slave mode), there are differences in the patches. I simply took the > > > changes from the chromeos-2.6.37 kernel and cherry-picked them into > > > the mainline kernel. Are the changes you posted re-written to address > > > issues that weren't solved in the ChromeOS kernel? > > > > > > Thanks for any feedback on this. > > Wei Ni wrote at Wednesday, April 20, 2011 8:09 PM: > > From: Wei Ni > > > > *** BLURB HERE *** > > > > Wei Ni (2): > > i2c: tegra: Retry transfer when unexpected/no_ack status is detected > > i2c: tegra: use new i2c slave controller > > > > drivers/i2c/busses/i2c-tegra.c | 57 > > +++++++++++++++++++++++++++++++++++++-- include/linux/i2c-tegra.h > > | 3 ++ > > 2 files changed, 57 insertions(+), 3 deletions(-) -- Dipl. Phys. Marc Dietrich Institut f?r Angewandte Physik - AG Kleink?hler - Justus-Liebig-Universit?t Gie?en Heinrich-Buff-Ring 16 D-35392 Gie?en Germany Tel. +49 641 99 33462 Fax. +49 641 99 33409 email: marc.dietrich@ap.physik.uni-giessen.de www: http://www.uni-giessen.de/cms/iap/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/