Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753812Ab1EDLhj (ORCPT ); Wed, 4 May 2011 07:37:39 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:48204 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752378Ab1EDLhh (ORCPT ); Wed, 4 May 2011 07:37:37 -0400 Message-ID: <4DC13A1B.8020004@ru.mvista.com> Date: Wed, 04 May 2011 15:35:55 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: Joe Perches CC: Oliver Neukum , David Brownell , Greg Kroah-Hartman , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] usbnet: Convert dbg to dev_dbg and neatening References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2586 Lines: 82 Hello. On 03-05-2011 22:17, Joe Perches wrote: > Use the more standard logging form. > Add a bit more tidying style. Style changes look rather doubtful to me... > Signed-off-by: Joe Perches > --- > drivers/net/usb/usbnet.c | 23 +++++++++++------------ > 1 files changed, 11 insertions(+), 12 deletions(-) > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > index 28aecbb..b803085 100644 > --- a/drivers/net/usb/usbnet.c > +++ b/drivers/net/usb/usbnet.c > @@ -192,8 +192,8 @@ static int init_status(struct usbnet *dev, struct usb_interface *intf) > return 0; > > pipe = usb_rcvintpipe(dev->udev, > - dev->status->desc.bEndpointAddress > - & USB_ENDPOINT_NUMBER_MASK); > + (dev->status->desc.bEndpointAddress > + & USB_ENDPOINT_NUMBER_MASK)); Why add parens? > @@ -1345,8 +1346,9 @@ usbnet_probe(struct usb_interface *udev, const struct usb_device_id *prod) > dev->intf = udev; > dev->driver_info = info; > dev->driver_name = name; > - dev->msg_enable = netif_msg_init(msg_level, NETIF_MSG_DRV > - | NETIF_MSG_PROBE | NETIF_MSG_LINK); > + dev->msg_enable = netif_msg_init(msg_level, (NETIF_MSG_DRV | > + NETIF_MSG_PROBE | > + NETIF_MSG_LINK)); Why add parens? > @@ -1466,8 +1468,7 @@ EXPORT_SYMBOL_GPL(usbnet_probe); > > /*-------------------------------------------------------------------------*/ > > -/* > - * suspend the whole driver as soon as the first interface is suspended > +/* suspend the whole driver as soon as the first interface is suspended Why? This already corresponded to the preferred multi-line comment style... > * resume only when the last interface is resumed > */ > > @@ -1485,16 +1486,14 @@ int usbnet_suspend(struct usb_interface *intf, pm_message_t message) > set_bit(EVENT_DEV_ASLEEP,&dev->flags); > spin_unlock_irq(&dev->txq.lock); > } > - /* > - * accelerate emptying of the rx and queues, to avoid > + /* accelerate emptying of the rx and queues, to avoid Why? > * having everything error out. > */ > netif_device_detach(dev->net); > usbnet_terminate_urbs(dev); > usb_kill_urb(dev->interrupt); > > - /* > - * reattach so runtime management can use and > + /* reattach so runtime management can use and Why? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/