Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753458Ab1EDNer (ORCPT ); Wed, 4 May 2011 09:34:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48392 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752185Ab1EDNeq (ORCPT ); Wed, 4 May 2011 09:34:46 -0400 Message-ID: <4DC155E7.1010802@redhat.com> Date: Wed, 04 May 2011 15:34:31 +0200 From: Tomas Henzl User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 MIME-Version: 1.0 To: scameron@beardog.cce.hp.com CC: james.bottomley@hansenpartnership.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, smcameron@yahoo.com, akpm@linux-foundation.org, mikem@beardog.cce.hp.com Subject: Re: [PATCH 01/16] hpsa: do readl after writel in main i/o path to ensure commands don't get lost. References: <20110503195750.5478.54853.stgit@beardog.cce.hp.com> <20110503195849.5478.13229.stgit@beardog.cce.hp.com> <4DC13566.5070203@redhat.com> <20110504125212.GC5997@beardog.cce.hp.com> In-Reply-To: <20110504125212.GC5997@beardog.cce.hp.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2454 Lines: 69 On 05/04/2011 02:52 PM, scameron@beardog.cce.hp.com wrote: > On Wed, May 04, 2011 at 01:15:50PM +0200, Tomas Henzl wrote: > >> On 05/03/2011 09:58 PM, Stephen M. Cameron wrote: >> >>> From: Stephen M. Cameron >>> >>> Apparently we've been doin it rong for a decade, but only lately do we >>> run into problems. >>> >>> Signed-off-by: Stephen M. Cameron >>> --- >>> drivers/scsi/hpsa.h | 1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >>> >>> diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h >>> index 621a153..98c97ca 100644 >>> --- a/drivers/scsi/hpsa.h >>> +++ b/drivers/scsi/hpsa.h >>> @@ -212,6 +212,7 @@ static void SA5_submit_command(struct ctlr_info *h, >>> dev_dbg(&h->pdev->dev, "Sending %x, tag = %x\n", c->busaddr, >>> c->Header.Tag.lower); >>> writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET); >>> + (void) readl(h->vaddr + SA5_REQUEST_PORT_OFFSET); >>> >>> >> Hi, >> a small nit - >> the (void) ^ is I think not needed for gcc and isn't present in the cciss.h patch >> > I just put it there to make it clear that it ignoring the return of readl is > done intentionally, not accidentally. If this goes against some coding convention, > whatever, I'm not super attached to the (void), but I did put it there on purpose, > and would have done it in cciss as well, had I thought of it at the time. > I'm not sure what the coding convention says about this, I personally would omit it, both ways are used in the kernel - so it is fine for me. Ack - Tomas > -- steve > > >> Tomas >> >> >>> h->commands_outstanding++; >>> if (h->commands_outstanding > h->max_outstanding) >>> h->max_outstanding = h->commands_outstanding; >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >>> > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/