Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753691Ab1EDQuk (ORCPT ); Wed, 4 May 2011 12:50:40 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:52071 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608Ab1EDQuj (ORCPT ); Wed, 4 May 2011 12:50:39 -0400 Date: Wed, 4 May 2011 18:50:21 +0200 From: Ingo Molnar To: Linus Torvalds Cc: Christoph Lameter , Thomas Gleixner , Tejun Heo , Pekka Enberg , Jens Axboe , Andrew Morton , werner , "H. Peter Anvin" , Linux Kernel Mailing List Subject: Re: [block IO crash] Re: 2.6.39-rc5-git2 boot crashs Message-ID: <20110504165021.GA1404@elte.hu> References: <20110504112746.GE8007@htj.dyndns.org> <20110504132022.GA17294@htj.dyndns.org> <20110504142532.GC17294@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1020 Lines: 30 * Linus Torvalds wrote: > My gut reaction would be: let's do the minimal patch that just fixes things > to do irqsafe_cpu_cmpxchg_double() for 2.6.39, and then let's remove the > #ifdef'fery in -rc1. [...] Looks like the sanest option IMHO, -rc7 is pretty late for anything than a few-liner patch. > [...] Or make _really_ sure that things are ok for platforms that never even > triggered the CMPXCHG_LOCAL case before. Considering that the status quo was !CMPXCHG_LOCAL in v2.6.38 and that lockless SLUB is an x86-only affair right now: $ git grep CMPXCHG_LOCAL arch/ arch/um/Kconfig.x86:config CMPXCHG_LOCAL arch/x86/Kconfig.cpu:config CMPXCHG_LOCAL There should be no problem with other architectures, right? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/