Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755313Ab1EDSRw (ORCPT ); Wed, 4 May 2011 14:17:52 -0400 Received: from mga11.intel.com ([192.55.52.93]:57445 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754929Ab1EDSRv (ORCPT ); Wed, 4 May 2011 14:17:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.64,315,1301900400"; d="scan'208";a="688192807" From: Andi Kleen To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andi Kleen , Michal Hocko , Dave Hansen , Balbir Singh , Johannes Weiner Subject: [PATCH] Allocate memory cgroup structures in local nodes Date: Wed, 4 May 2011 11:17:38 -0700 Message-Id: <1304533058-18228-1-git-send-email-andi@firstfloor.org> X-Mailer: git-send-email 1.7.4.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1707 Lines: 49 From: Andi Kleen [Andrew: since this is a regression and a very simple fix could you still consider it for .39? Thanks] dde79e005a769 added a regression that the memory cgroup data structures all end up in node 0 because the first attempt at allocating them would not pass in a node hint. Since the initialization runs on CPU #0 it would all end up node 0. This is a problem on large memory systems, where node 0 would lose a lot of memory. Change the alloc_pages_exact to alloc_pages_exact_node. This will still fall back to other nodes if not enough memory is available. [RED-PEN: right now it would fall back first before trying vmalloc_node. Probably not the best strategy ... But I left it like that for now.] Reported-by: Doug Nelson CC: Michal Hocko Cc: Dave Hansen Cc: Balbir Singh Cc: Johannes Weiner Signed-off-by: Andi Kleen --- mm/page_cgroup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c index 9905501..1f4e20f 100644 --- a/mm/page_cgroup.c +++ b/mm/page_cgroup.c @@ -134,7 +134,7 @@ static void *__init_refok alloc_page_cgroup(size_t size, int nid) { void *addr = NULL; - addr = alloc_pages_exact(size, GFP_KERNEL | __GFP_NOWARN); + addr = alloc_pages_exact_node(nid, size, GFP_KERNEL | __GFP_NOWARN); if (addr) return addr; -- 1.7.4.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/