Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755300Ab1EDT2E (ORCPT ); Wed, 4 May 2011 15:28:04 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:37254 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753994Ab1EDT2C (ORCPT ); Wed, 4 May 2011 15:28:02 -0400 Content-Type: text/plain; charset=UTF-8 From: Chris Mason To: Christoph Hellwig Cc: "Darrick J. Wong" , "Theodore Ts'o" , Jeff Layton , Jan Kara , Dave Chinner , Joel Becker , "Martin K. Petersen" , Jens Axboe , linux-kernel , linux-fsdevel , Mingming Cao , linux-scsi , Dave Hansen , linux-mm Subject: Re: [PATCH v3 0/3] data integrity: Stabilize pages during writeback for ext4 In-reply-to: <20110504184644.GA23246@infradead.org> References: <20110406232938.GF1110@tux1.beaverton.ibm.com> <20110407165700.GB7363@quack.suse.cz> <20110408203135.GH1110@tux1.beaverton.ibm.com> <20110411124229.47bc28f6@corrin.poochiereds.net> <1302543595-sup-4352@think> <1302569212.2580.13.camel@mingming-laptop> <20110412005719.GA23077@infradead.org> <1302742128.2586.274.camel@mingming-laptop> <20110422000226.GA22189@tux1.beaverton.ibm.com> <20110504173704.GE20579@tux1.beaverton.ibm.com> <20110504184644.GA23246@infradead.org> Date: Wed, 04 May 2011 15:21:55 -0400 Message-Id: <1304536162-sup-3721@think> User-Agent: Sup/git Content-Transfer-Encoding: 8bit X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4DC1A774.00B2:SCFMA922111,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1333 Lines: 31 Excerpts from Christoph Hellwig's message of 2011-05-04 14:46:44 -0400: > This seems to miss out on a lot of the generic functionality like > write_cache_pages and block_page_mkwrite and just patch it into > the ext4 copy & paste variants. Please make sure your patches also > work for filesystem that use more of the generic functionality like > xfs or ext2 (the latter one might be fun for the mmap case). Probably after the block_commit_write in block_page_mkwrite() Another question is, do we want to introduce a wait_on_stable_page_writeback()? This would allow us to add a check against the bdi requesting stable pages. > > Also what's the status of btrfs? I remembered there was one or two > bits missing despite doing the right thing in most areas. As far as I know btrfs is getting it right. The only bit missing is the one Nick Piggin pointed out where it is possible to change mmap'd O_DIRECT memory in flight while a DIO is in progress. Josef has a test case that demonstrates this. Nick had a plan to fix it, but it involved redoing the get_user_pages api. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/