Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755222Ab1EDTyM (ORCPT ); Wed, 4 May 2011 15:54:12 -0400 Received: from smtp.microsoft.com ([131.107.115.214]:46355 "EHLO smtp.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753999Ab1EDTyL convert rfc822-to-8bit (ORCPT ); Wed, 4 May 2011 15:54:11 -0400 From: KY Srinivasan To: Greg KH , Randy Dunlap CC: "virtualization@lists.osdl.org" , "devel@linuxdriverproject.org" , "H Hartley Sweeten" , Haiyang Zhang , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig Thread-Topic: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv Kconfig Thread-Index: AQHMCpLf+Tgs2WMuh0+2REfaNUpg85R9hkgA//+N7aA= Date: Wed, 4 May 2011 19:54:09 +0000 Message-ID: <6E21E5352C11B742B20C142EB499E0481DFE61@TK5EX14MBXC124.redmond.corp.microsoft.com> References: <1304535105-26892-1-git-send-email-kys@microsoft.com> <0D753D10438DA54287A00B027084269764D295CE91@AUSP01VMBX24.collaborationhost.net> <20110504185338.GB9823@suse.de> <20110504123302.1ef22682.rdunlap@xenotime.net> <20110504193954.GA30937@suse.de> In-Reply-To: <20110504193954.GA30937@suse.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [157.54.51.33] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2384 Lines: 62 > -----Original Message----- > From: devel-bounces@linuxdriverproject.org [mailto:devel- > bounces@linuxdriverproject.org] On Behalf Of Greg KH > Sent: Wednesday, May 04, 2011 3:40 PM > To: Randy Dunlap > Cc: virtualization@lists.osdl.org; devel@linuxdriverproject.org; H Hartley > Sweeten; Haiyang Zhang; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv > Kconfig > > On Wed, May 04, 2011 at 12:33:02PM -0700, Randy Dunlap wrote: > > On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote: > > > > > On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote: > > > > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote: > > > > > > > > > > The vmbus driver dependes on ACPI and PCI subsystems. Change > > > > > Kconfig to reflect this. > > > > > > > > > > Signed-off-by: K. Y. Srinivasan > > > > > Signed-off-by: Haiyang Zhang > > > > > --- > > > > > drivers/staging/hv/Kconfig | 2 +- > > > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > > > > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig > > > > > index 76f0756..5e0c9f6 100644 > > > > > --- a/drivers/staging/hv/Kconfig > > > > > +++ b/drivers/staging/hv/Kconfig > > > > > @@ -1,6 +1,6 @@ > > > > > config HYPERV > > > > > tristate "Microsoft Hyper-V client drivers" > > > > > - depends on X86 && m > > > > > + depends on X86 && ACPI && PCI && m > > > > > default n > > > > > help > > > > > Select this option to run Linux as a Hyper-V client operating > > > > > > > > ACPI itself depends on PCI. > > > > > > Still? I thought that got removed a while ago. > > > > Still. Len has written in the past that technically there is no such > > dependency, but in reality there is, for now at least. IIRC. > > Ok, but then we should still say we depend on PCI to handle if/when ACPI > removes that dependancy in the future. It doesn't hurt here at all. Greg, I have sent you both versions of this patch; one with explicit dependency on PCI and one with implicit dependency on PCI; you decide. Regards, K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/