Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755583Ab1EDUAk (ORCPT ); Wed, 4 May 2011 16:00:40 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:49245 "EHLO e4.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755068Ab1EDUAi (ORCPT ); Wed, 4 May 2011 16:00:38 -0400 Date: Wed, 4 May 2011 13:00:31 -0700 From: "Darrick J. Wong" To: Chris Mason Cc: Christoph Hellwig , "Theodore Ts'o" , Jeff Layton , Jan Kara , Dave Chinner , Joel Becker , "Martin K. Petersen" , Jens Axboe , linux-kernel , linux-fsdevel , Mingming Cao , linux-scsi , Dave Hansen , linux-mm Subject: Re: [PATCH v3 0/3] data integrity: Stabilize pages during writeback for ext4 Message-ID: <20110504200031.GI20579@tux1.beaverton.ibm.com> Reply-To: djwong@us.ibm.com References: <20110408203135.GH1110@tux1.beaverton.ibm.com> <20110411124229.47bc28f6@corrin.poochiereds.net> <1302543595-sup-4352@think> <1302569212.2580.13.camel@mingming-laptop> <20110412005719.GA23077@infradead.org> <1302742128.2586.274.camel@mingming-laptop> <20110422000226.GA22189@tux1.beaverton.ibm.com> <20110504173704.GE20579@tux1.beaverton.ibm.com> <20110504184644.GA23246@infradead.org> <1304536162-sup-3721@think> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1304536162-sup-3721@think> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1784 Lines: 41 On Wed, May 04, 2011 at 03:21:55PM -0400, Chris Mason wrote: > Excerpts from Christoph Hellwig's message of 2011-05-04 14:46:44 -0400: > > This seems to miss out on a lot of the generic functionality like > > write_cache_pages and block_page_mkwrite and just patch it into > > the ext4 copy & paste variants. Please make sure your patches also > > work for filesystem that use more of the generic functionality like > > xfs or ext2 (the latter one might be fun for the mmap case). > > Probably after the block_commit_write in block_page_mkwrite() Yes, I'm working on providing more generic fixes for ext3 & friends too, but they're not really working yet, so I was posting the parts that fix ext4, since they seem usable. > Another question is, do we want to introduce a wait_on_stable_page_writeback()? > > This would allow us to add a check against the bdi requesting stable > pages. Sounds like a good idea. > > Also what's the status of btrfs? I remembered there was one or two > > bits missing despite doing the right thing in most areas. > > As far as I know btrfs is getting it right. The only bit missing is the > one Nick Piggin pointed out where it is possible to change mmap'd O_DIRECT > memory in flight while a DIO is in progress. Josef has a test case that > demonstrates this. > > Nick had a plan to fix it, but it involved redoing the get_user_pages > api. I ran the same six tests A-F on btrfs and it reported -ENOSPC with 1% of the space used, though until it did that I didn't see any checksum errors. --D -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/