Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756161Ab1EDWZU (ORCPT ); Wed, 4 May 2011 18:25:20 -0400 Received: from mail.candelatech.com ([208.74.158.172]:33178 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755970Ab1EDWZS (ORCPT ); Wed, 4 May 2011 18:25:18 -0400 Message-ID: <4DC1D1A5.7050408@candelatech.com> Date: Wed, 04 May 2011 15:22:29 -0700 From: Ben Greear Organization: Candela Technologies User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc11 Thunderbird/3.0.4 MIME-Version: 1.0 To: Linus Torvalds CC: Ingo Molnar , Thomas Gleixner , Tejun Heo , Pekka Enberg , Jens Axboe , Andrew Morton , werner , "H. Peter Anvin" , Linux Kernel Mailing List , Christoph Lameter Subject: Re: [PATCH] slub: Fix the lockless code on 32-bit platforms with no 64-bit cmpxchg References: <20110504083559.GB25724@elte.hu> <20110504101932.GA3392@elte.hu> <20110504112746.GE8007@htj.dyndns.org> <20110504132022.GA17294@htj.dyndns.org> <20110504141413.GA14127@elte.hu> <20110504143616.GA19986@elte.hu> <4DC1CAB8.5080305@candelatech.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1446 Lines: 40 On 05/04/2011 03:00 PM, Linus Torvalds wrote: > On Wed, May 4, 2011 at 2:52 PM, Ben Greear wrote: >> >> This patch appears to fix the crashes I was seeing on my 32-bit >> Atom system. >> >> It would crash within 30 seconds of booting every time before this patch... > > Oh, well - I already committed it and pushed out, otherwise I'd have > added that piece of information to the commit log. No worries...I'm just happy to finally be able to boot .39 :) > But it's good to know that others had seen this too, just never > realized what was going on. > > Btw, that does seem to imply that your kernel config is somewhat odd. > We _should_ be using cmpxchg8b natively if you compile for anything > newer than PPro, and that includes atom. > > Did you perhaps say "compile for Pentium" (which is pretty close to > Atom in some respects - but we don't trust that all Pentium-class > CPU's have cmpxchg8b, even if the Intel ones all should). Well, yes. I'm compiling for 'M586' it seems, plus SMP, pre-empt, etc. Maybe it's time to move to a newer processor family! Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/