Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752822Ab1EECEY (ORCPT ); Wed, 4 May 2011 22:04:24 -0400 Received: from mga03.intel.com ([143.182.124.21]:39036 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752334Ab1EECEU (ORCPT ); Wed, 4 May 2011 22:04:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.64,317,1301900400"; d="scan'208";a="430792279" Message-Id: <20110505020417.586891398@sli10-conroe.sh.intel.com> User-Agent: quilt/0.48-1 Date: Thu, 05 May 2011 09:59:33 +0800 From: shaohua.li@intel.com To: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Cc: jaxboe@fusionio.com, htejun@gmail.com, hch@infradead.org, jgarzik@pobox.com, djwong@us.ibm.com, sshtylyov@mvista.com, Shaohua Li Subject: [patch v3 1/3] block: add a non-queueable flush flag References: <20110505015932.306763905@sli10-conroe.sh.intel.com> Content-Disposition: inline; filename=blk-nonqueueable-flush-flag.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2541 Lines: 65 flush request isn't queueable in some drives. Add a flag to let driver notify block layer about this. We can optimize flush performance with the knowledge. Signed-off-by: Shaohua Li --- block/blk-settings.c | 6 ++++++ include/linux/blkdev.h | 7 +++++++ 2 files changed, 13 insertions(+) Index: linux/include/linux/blkdev.h =================================================================== --- linux.orig/include/linux/blkdev.h 2011-05-04 14:23:42.000000000 +0800 +++ linux/include/linux/blkdev.h 2011-05-05 09:05:18.000000000 +0800 @@ -364,6 +364,7 @@ struct request_queue * for flush operations */ unsigned int flush_flags; + unsigned int flush_not_queueable:1; unsigned int flush_pending_idx:1; unsigned int flush_running_idx:1; unsigned long flush_pending_since; @@ -843,6 +844,7 @@ extern void blk_queue_softirq_done(struc extern void blk_queue_rq_timed_out(struct request_queue *, rq_timed_out_fn *); extern void blk_queue_rq_timeout(struct request_queue *, unsigned int); extern void blk_queue_flush(struct request_queue *q, unsigned int flush); +extern void blk_queue_flush_queueable(struct request_queue *q, bool queueable); extern struct backing_dev_info *blk_get_backing_dev_info(struct block_device *bdev); extern int blk_rq_map_sg(struct request_queue *, struct request *, struct scatterlist *); @@ -1111,6 +1113,11 @@ static inline unsigned int block_size(st return bdev->bd_block_size; } +static inline bool queue_flush_queueable(struct request_queue *q) +{ + return !q->flush_not_queueable; +} + typedef struct {struct page *v;} Sector; unsigned char *read_dev_sector(struct block_device *, sector_t, Sector *); Index: linux/block/blk-settings.c =================================================================== --- linux.orig/block/blk-settings.c 2011-05-05 08:37:05.000000000 +0800 +++ linux/block/blk-settings.c 2011-05-05 09:02:16.000000000 +0800 @@ -790,6 +790,12 @@ void blk_queue_flush(struct request_queu } EXPORT_SYMBOL_GPL(blk_queue_flush); +void blk_queue_flush_queueable(struct request_queue *q, bool queueable) +{ + q->flush_not_queueable = !queueable; +} +EXPORT_SYMBOL_GPL(blk_queue_flush_queueable); + static int __init blk_settings_init(void) { blk_max_low_pfn = max_low_pfn - 1; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/