DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=uquna0ORZwpIMypft7PTDOSkgyMYTMB5ElPnk1DZCihIY1ENcwng9MJ92TsLZcKnwQ
         yl4fYO/CL68sEx7yjQcGZg3q5iBPDWAQIyyu+9ujRSJq8rGTLr3tZdysQ9s4zSW57iRw
         5oBN7nAx8agrnrd/ZLza25XsdbjYrwhYY+tJk=
Subject: Re: [PATCH] time: Add locking to xtime access in get_seconds()
From: Eric Dumazet <eric.dumazet@gmail.com>
To: john stultz <johnstul@us.ibm.com>
Cc: Andi Kleen <andi@firstfloor.org>, lkml <linux-kernel@vger.kernel.org>,
        Paul Mackerras <paulus@samba.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Anton Blanchard <anton@samba.org>,
        Thomas Gleixner <tglx@linutronix.de>
In-Reply-To: <1304576495.2943.40.camel@work-vm>
References: <1304478708-1273-1-git-send-email-john.stultz@linaro.org>
	 <m2oc3jxgtt.fsf@firstfloor.org>  <1304564090.2943.36.camel@work-vm>
	 <1304574244.32152.666.camel@edumazet-laptop>
	 <1304576495.2943.40.camel@work-vm>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 05 May 2011 08:50:31 +0200
Message-ID: <1304578231.32152.781.camel@edumazet-laptop>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 578
Lines: 17

Le mercredi 04 mai 2011 à 23:21 -0700, john stultz a écrit :

> Would a comment to the effect of "ensure processors don't re-order calls
> to get_seconds" help, or is it still too opaque (or even still
> nonsense?).
> 

Where is corresponding smp_wmb() ? It's not obvious, so you must add a
comment to help reader of this code.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/