Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753537Ab1EFGpU (ORCPT ); Fri, 6 May 2011 02:45:20 -0400 Received: from mga11.intel.com ([192.55.52.93]:47430 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753152Ab1EFGpO convert rfc822-to-8bit (ORCPT ); Fri, 6 May 2011 02:45:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.64,325,1301900400"; d="scan'208";a="688991983" From: "Tian, Kevin" To: "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , "hpa@zytor.com" , "tglx@linutronix.de" CC: Ian Campbell , "JBeulich@novell.com" , "xen-devel@lists.xensource.com" Date: Fri, 6 May 2011 14:43:36 +0800 Subject: [PATCH v2 1/2] x86: skip migrating IRQF_PER_CPU irq in fixup_irqs Thread-Topic: [PATCH v2 1/2] x86: skip migrating IRQF_PER_CPU irq in fixup_irqs Thread-Index: AcwLuG0kAnDONFTeQEeF45iftKIKYA== Message-ID: <625BA99ED14B2D499DC4E29D8138F1505C8ED7F7E2@shsmsx502.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1443 Lines: 33 x86: skip migrating IRQF_PER_CPU irq in fixup_irqs IRQF_PER_CPU marks a irq binding to a specific cpu, and can never be moved away from that cpu. So it shouldn't be migrated when fixup irqs to offline a cpu. Xen pvops guest is one source using IRQF_PER_CPU on a set of virtual interrupts. Previously no error is observed because Xen event chip silently fails the set_affinity ops, and logically IRQF_PER_CPU should be recognized here. Signed-off-by: Fengzhe Zhang Signed-off-by: Kevin Tian CC: Thomas Gleixner CC: Ingo Molnar CC: H. Peter Anvin CC: Ian Campbell CC: Jan Beulich --- linux-2.6.39-rc6.orig/arch/x86/kernel/irq.c 2011-05-04 10:59:13.000000000 +0800 +++ linux-2.6.39-rc6/arch/x86/kernel/irq.c 2011-05-06 09:20:25.563963000 +0800 @@ -249,7 +250,7 @@ void fixup_irqs(void) data = irq_desc_get_irq_data(desc); affinity = data->affinity; - if (!irq_has_action(irq) || + if (!irq_has_action(irq) || irqd_is_per_cpu(data) || cpumask_subset(affinity, cpu_online_mask)) { raw_spin_unlock(&desc->lock); continue; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/