Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756226Ab1EFKHe (ORCPT ); Fri, 6 May 2011 06:07:34 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:39121 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755111Ab1EFKHd (ORCPT ); Fri, 6 May 2011 06:07:33 -0400 Message-ID: <4DC3C7FC.9050807@mvista.com> Date: Fri, 06 May 2011 14:05:48 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: David Daney CC: linux-mips@linux-mips.org, ralf@linux-mips.org, devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v3 2/6] of: Make of_find_node_by_path() traverse /aliases for relative paths. References: <1304614949-30460-1-git-send-email-ddaney@caviumnetworks.com> <1304614949-30460-3-git-send-email-ddaney@caviumnetworks.com> In-Reply-To: <1304614949-30460-3-git-send-email-ddaney@caviumnetworks.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1791 Lines: 60 Hello. On 05-05-2011 21:02, David Daney wrote: > Currently all paths passed to of_find_node_by_path() must begin with a > '/', indicating a full path to the desired node. > Augment the look-up code so that if a path does *not* begin with '/', > the path is used as the name of an /aliases property. The value of > this alias is then used as the full node path to be found. > Signed-off-by: David Daney > --- > drivers/of/base.c | 41 ++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 40 insertions(+), 1 deletions(-) > diff --git a/drivers/of/base.c b/drivers/of/base.c > index 632ebae..1a0a83e 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c [...] > @@ -348,14 +351,50 @@ EXPORT_SYMBOL(of_get_next_child); > struct device_node *of_find_node_by_path(const char *path) > { > struct device_node *np = allnodes; > + struct device_node *aliases = NULL; > + char *alias = NULL; > + char *new_path = NULL; > > read_lock(&devtree_lock); > + > + if (path[0] != '/') { > + const char *ps; > + aliases = of_find_node_by_path("/aliases"); > + if (!aliases) > + goto out; > + > + ps = strchr(path, '/'); > + if (ps) { > + size_t len = ps - path; > + alias = kmalloc(len + 1, GFP_KERNEL); How about error handling? > + strncpy(alias, path, len); > + alias[len] = 0; > + path = of_get_property(aliases, alias, NULL); > + if (!path) > + goto out; > + len = strlen(path) + strlen(ps) + 1; > + new_path = kmalloc(len, GFP_KERNEL); Here too... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/