Date: Sat, 7 May 2011 09:05:50 +0900
To: konrad.wilk@oracle.com
Cc: fujita.tomonori@lab.ntt.co.jp, mcree@orcon.net.nz,
        linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
        mattst88@gmail.com, rth@twiddle.net, ink@jurassic.park.msu.ru
Subject: Re: [PATCH] alpha: Add DMA_ERROR_CODE defn to avert compiler error
 in drm
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
In-Reply-To: <20110506134925.GB5500@dumpdata.com>
References: <1304496817-7646-1-git-send-email-mcree@orcon.net.nz>
	<20110506212708I.fujita.tomonori@lab.ntt.co.jp>
	<20110506134925.GB5500@dumpdata.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20110507090257L.fujita.tomonori@lab.ntt.co.jp>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1167
Lines: 24

On Fri, 6 May 2011 09:49:25 -0400
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:

> On Fri, May 06, 2011 at 09:30:03PM +0900, FUJITA Tomonori wrote:
> > On Wed,  4 May 2011 20:13:37 +1200
> > Michael Cree <mcree@orcon.net.nz> wrote:
> > 
> > > The radeon drm code now relies on DMA_ERROR_CODE.  This defines
> > > it in alpha dma-mapping header to at least enable me to compile
> > > radeon drm/kms into kernel.
> > > 
> > > Signed-off-by: Michael Cree <mcree@orcon.net.nz>
> > > ---
> > >  arch/alpha/include/asm/dma-mapping.h |    2 ++
> > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > This isn't correct. The drivers should not use DMA_ERROR_CODE directly
> > (some architecture specific drivers use it though). Fix rademon
> > drm/kms instead.
> 
> What would be a proper value for non-existent bus addresses? As in the value
> had not been set? 0?

Zero is a valid DMA address for some devices.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/