Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932112Ab1EGXWW (ORCPT ); Sat, 7 May 2011 19:22:22 -0400 Received: from sh.osrg.net ([192.16.179.4]:59082 "EHLO sh.osrg.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756306Ab1EGXWT (ORCPT ); Sat, 7 May 2011 19:22:19 -0400 Date: Sun, 8 May 2011 08:21:40 +0900 To: konrad.wilk@oracle.com Cc: fujita.tomonori@lab.ntt.co.jp, mcree@orcon.net.nz, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, mattst88@gmail.com, rth@twiddle.net, ink@jurassic.park.msu.ru Subject: Re: [PATCH] alpha: Add DMA_ERROR_CODE defn to avert compiler error in drm From: FUJITA Tomonori In-Reply-To: <20110507030803.GA18069@dumpdata.com> References: <20110506134925.GB5500@dumpdata.com> <20110507090257L.fujita.tomonori@lab.ntt.co.jp> <20110507030803.GA18069@dumpdata.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20110507175442N.fujita.tomonori@lab.ntt.co.jp> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (sh.osrg.net [192.16.179.4]); Sun, 08 May 2011 08:21:42 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1618 Lines: 35 On Fri, 6 May 2011 23:08:03 -0400 Konrad Rzeszutek Wilk wrote: > On Sat, May 07, 2011 at 09:05:50AM +0900, FUJITA Tomonori wrote: > > On Fri, 6 May 2011 09:49:25 -0400 > > Konrad Rzeszutek Wilk wrote: > > > > > On Fri, May 06, 2011 at 09:30:03PM +0900, FUJITA Tomonori wrote: > > > > On Wed, 4 May 2011 20:13:37 +1200 > > > > Michael Cree wrote: > > > > > > > > > The radeon drm code now relies on DMA_ERROR_CODE. This defines > > > > > it in alpha dma-mapping header to at least enable me to compile > > > > > radeon drm/kms into kernel. > > > > > > > > > > Signed-off-by: Michael Cree > > > > > --- > > > > > arch/alpha/include/asm/dma-mapping.h | 2 ++ > > > > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > > > > > This isn't correct. The drivers should not use DMA_ERROR_CODE directly > > > > (some architecture specific drivers use it though). Fix rademon > > > > drm/kms instead. > > > > > > What would be a proper value for non-existent bus addresses? As in the value > > > had not been set? 0? > > > > Zero is a valid DMA address for some devices. > > Ok, so what is an invalid DMA address? You are looking for a DMA address that is invalid for any device? If so, there is no such thing because as I wrote, it depends on how a device does DMA. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/