Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752189Ab1EHC1L (ORCPT ); Sat, 7 May 2011 22:27:11 -0400 Received: from relay3.ukrpost.ua ([82.207.79.23]:33700 "EHLO relay3.ukrpost.ua" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542Ab1EHC1H (ORCPT ); Sat, 7 May 2011 22:27:07 -0400 X-Greylist: delayed 1108 seconds by postgrey-1.27 at vger.kernel.org; Sat, 07 May 2011 22:27:07 EDT X-Spam-Processed: mail.academy.zt.ua, Sun, 08 May 2011 05:07:23 +0300 (not processed: message from trusted or authenticated source) X-Authenticated-Sender: george@academy.zt.ua X-HashCash: 1:20:110508:md50000002783::4P3QTHZ42nUNCXlM:00000YFT X-Return-Path: prvs=110986adc1=george@znau.edu.ua X-Envelope-From: george@znau.edu.ua X-MDaemon-Deliver-To: linux-kernel@vger.kernel.org Subject: Re: [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver From: George Kashperko To: Michael =?ISO-8859-1?Q?B=FCsch?= Cc: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Arnd Bergmann , linux-wireless@vger.kernel.org, "John W. Linville" , b43-dev@lists.infradead.org, Greg KH , Michael =?ISO-8859-1?Q?B=FCsch?= , Larry Finger , Arend van Spriel , linux-arm-kernel@lists.infradead.org, Russell King , Andy Botting , linuxdriverproject , "linux-kernel@vger.kernel.org" In-Reply-To: <1304819081.21680.6.camel@maggie> References: <1304632783-8781-1-git-send-email-zajec5@gmail.com> <201105061605.31625.arnd@arndb.de> <1304790665.13983.10.camel@dev.znau.edu.ua> <1304792795.13983.28.camel@dev.znau.edu.ua> <1304794931.13983.44.camel@dev.znau.edu.ua> <1304796956.13983.65.camel@dev.znau.edu.ua> <1304819081.21680.6.camel@maggie> Content-Type: text/plain Date: Sun, 08 May 2011 05:01:09 +0300 Message-Id: <1304820069.13983.82.camel@dev.znau.edu.ua> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-19.el5) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1851 Lines: 50 > On Sat, 2011-05-07 at 22:35 +0300, George Kashperko wrote: > > dbg_bcma_device_name > > { > > #ifdef DEBUG > > case/switch/if/else stuff > > #endif > > return NULL; > > } > > But I don't see here much sense to hardcode names other than those of > > buscommons/buscores for debugging purposes. > > Would you please read and understand the code before discussing this? > That would help the discussion on the technical side. > > Those names are hardcoded by definition. And just like 14e4 is the PCI > ID for Broadcom devices, 800 is the AXI ID for Broadcom Chipcommon. > > And building an #ifdef mess around this stuff is not better than having > a few bytes of _helpful_ information messages. > You are absolutely right that those messages only help 1% of the people. > Just as _any_ other kernel message. > Following is first part of my comment with "case/switch/if/else stuff" which you didn't quoted and which I was actually commented at: > > How do you see relation between bcma_device_name and: > > int zd_ioread32v_locked(...) { > > if (r) { > > dev_dbg_f(zd_chip_dev(chip), > > "error: zd_ioread16v_locked. Error number %d\n", r); > > return r; > > } > } > No relation at all. It like comparing warm and soft. It will be if you > do something like Original discussion on the bcma_device_name was started by Arend pointing that there can be cores with same id but different vendor code. As one among ways to deal with this I've proposed to remove bcma_device_name and let drivers supply core name. Have nice day, George -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/