Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753139Ab1EIHo1 (ORCPT ); Mon, 9 May 2011 03:44:27 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:45517 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751253Ab1EIHo0 (ORCPT ); Mon, 9 May 2011 03:44:26 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Stephen Wilson Subject: Re: [PATCH 3/8] mm: remove MPOL_MF_STATS Cc: kosaki.motohiro@jp.fujitsu.com, Andrew Morton , Alexander Viro , Hugh Dickins , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <1303947349-3620-4-git-send-email-wilsons@start.ca> References: <1303947349-3620-1-git-send-email-wilsons@start.ca> <1303947349-3620-4-git-send-email-wilsons@start.ca> Message-Id: <20110509164609.1657.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.56.05 [ja] Date: Mon, 9 May 2011 16:44:24 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2214 Lines: 66 > Mapping statistics in a NUMA environment is now computed using the > generic walk_page_range() logic. Remove the old/equivalent > functionality. > > Signed-off-by: Stephen Wilson > --- > mm/mempolicy.c | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index dfe27e3..63c0d69 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -99,7 +99,6 @@ > /* Internal flags */ > #define MPOL_MF_DISCONTIG_OK (MPOL_MF_INTERNAL << 0) /* Skip checks for continuous vmas */ > #define MPOL_MF_INVERT (MPOL_MF_INTERNAL << 1) /* Invert check for nodemask */ > -#define MPOL_MF_STATS (MPOL_MF_INTERNAL << 2) /* Gather statistics */ > > static struct kmem_cache *policy_cache; > static struct kmem_cache *sn_cache; > @@ -492,9 +491,7 @@ static int check_pte_range(struct vm_area_struct *vma, pmd_t *pmd, > if (node_isset(nid, *nodes) == !!(flags & MPOL_MF_INVERT)) > continue; > > - if (flags & MPOL_MF_STATS) > - gather_stats(page, private, pte_dirty(*pte)); > - else if (flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL)) > + if (flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL)) > migrate_page_add(page, private, flags); > else > break; This hunk looks good to me. > @@ -2572,6 +2569,7 @@ static int gather_pte_stats(pte_t *pte, unsigned long addr, > unsigned long pte_size, struct mm_walk *walk) > { > struct page *page; > + int nid; > > if (pte_none(*pte)) > return 0; > @@ -2580,6 +2578,10 @@ static int gather_pte_stats(pte_t *pte, unsigned long addr, > if (!page) > return 0; > > + nid = page_to_nid(page); > + if (!node_isset(nid, node_states[N_HIGH_MEMORY])) > + return 0; > + > gather_stats(page, walk->private, pte_dirty(*pte)); > return 0; However this hunk should be moved into patch [2/8]. because 1) keeping bisectability 2) The description says "Remove the old/equivalent functionality." but it added new functionality. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/