Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753343Ab1EIIQv (ORCPT ); Mon, 9 May 2011 04:16:51 -0400 Received: from eu1sys200aog104.obsmtp.com ([207.126.144.117]:60067 "EHLO eu1sys200aog104.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753581Ab1EIIQr (ORCPT ); Mon, 9 May 2011 04:16:47 -0400 Message-ID: <4DC7A2DB.3040601@st.com> Date: Mon, 9 May 2011 13:46:27 +0530 From: viresh kumar User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: "Koul, Vinod" Cc: "dan.j.williams@intel.com" , "linux-kernel@vger.kernel.org" , Armando VISCONTI , Shiraz HASHIM , "linux-arm-kernel@lists.infradead.org" , "viresh.linux@gmail.com" , "linux@arm.linux.org.uk" Subject: Re: [PATCH V4 3/5] dmaengine/dw_dmac: Divide one sg to many desc, if sg len is greater than DWC_MAX_COUNT References: <1304918425.32447.20.camel@vkoul-udesk3> <4DC783A9.5060802@st.com> <1304920041.32447.33.camel@vkoul-udesk3> <4DC78ABB.2030800@st.com> <1304921462.32447.35.camel@vkoul-udesk3> In-Reply-To: <1304921462.32447.35.camel@vkoul-udesk3> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1038 Lines: 28 On 05/09/2011 11:41 AM, Koul, Vinod wrote: > On Mon, 2011-05-09 at 12:03 +0530, viresh kumar wrote: >> On 05/09/2011 11:17 AM, Koul, Vinod wrote: >>> Ah, then there is another todo for this driver. Move from chan->private >>> to DMA_SLAVE_CONFIG. >>> >>> struct dma_slave_config has dedicated fields for both source and >>> destination widths, src_addr_width & dst_addr_width please use them... >>> You should pass this structure to device control API as: >>> dmaengine_device_control( >>> chan, DMA_SLAVE_CONFIG, (unsigned long)&slave_config); >> >> As soon as i get some time, will study & implement this. >> For now, please push this patchset (if it looks fine). >> > rest looks OK. Please fix the patch1. > > I am resending all 5 patches, so that they get rebased cleanly. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/