Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753536Ab1EINzD (ORCPT ); Mon, 9 May 2011 09:55:03 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:60748 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753327Ab1EINzC (ORCPT ); Mon, 9 May 2011 09:55:02 -0400 Date: Mon, 9 May 2011 14:55:34 +0100 From: Alan Cox To: "Subhasish Ghosh" Cc: , "Greg Kroah-Hartman" , , , , , "Andrew Morton \(commit_signer:1/4=25%\)" , "Randy Dunlap \(commit_signer:1/4=25%\)" , "open list" Subject: Re: [PATCH v4 08/11] tty: add pruss SUART driver Message-ID: <20110509145534.2677dfa1@lxorguk.ukuu.org.uk> In-Reply-To: <3A9C5CD56396439DBF825BB4E5779DB9@subhasishg> References: <1303474109-6212-1-git-send-email-subhasish@mistralsolutions.com> <1303474109-6212-9-git-send-email-subhasish@mistralsolutions.com> <034A6447E0D54737B5CEE009A4D20B37@subhasishg> <20110509144610.6b4f7090@lxorguk.ukuu.org.uk> <3A9C5CD56396439DBF825BB4E5779DB9@subhasishg> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 976 Lines: 23 On Mon, 9 May 2011 19:20:17 +0530 "Subhasish Ghosh" wrote: > >> I then modified this function to as follows and the error is not observed > >> anymore. > > > > That looks like you are somehow calling uart_carrier_raised somewhere > > with interrupts disabled ? > > > I am not calling this function in my driver atall, this is getting called by > tty_port.c Can you verify the status of the interrupt flags at the point that routine is called in your code and get a backtrace of the path. It should never be gettng called with interrupts off, and if it is we need to know what the path is. Otherwise that code change would imply a bug in the core code for the platform which seems less likely. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/