Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754033Ab1EITK7 (ORCPT ); Mon, 9 May 2011 15:10:59 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:38380 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751933Ab1EITK6 (ORCPT ); Mon, 9 May 2011 15:10:58 -0400 Date: Mon, 09 May 2011 12:10:26 -0700 (PDT) Message-Id: <20110509.121026.28826727.davem@davemloft.net> To: joe@perches.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 5/4] tulip: xircom_cb: Remove useless func_enter and func_exit From: David Miller In-Reply-To: <1304968081.19586.66.camel@Joe-Laptop> References: <20110509.114706.189685729.davem@davemloft.net> <1304968081.19586.66.camel@Joe-Laptop> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 27 From: Joe Perches Date: Mon, 09 May 2011 12:08:01 -0700 > On Mon, 2011-05-09 at 11:47 -0700, David Miller wrote: >> With the advent of the function tracer, those silly function entry/exit >> logging things are entirely superfluous. >> They make the code look ugly too. > > I don't much like a lot of debugging messages > throughout drivers/net, but that's a whole 'nother > set of patches. > >> Please do that and respin this patch set, thanks Joe! > > How 'bout I just add another patch to delete them. > > Signed-off-by: Joe Perches How about you just respin the patch set as I asked you to? It makes no sense to "fix" something you're just going to delete in the very next commit. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/