Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755909Ab1EIXxh (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 May 2011 19:53:37 -0400
Received: from smtp.microsoft.com ([131.107.115.214]:18459 "EHLO
	smtp.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755765Ab1EIXxg convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 May 2011 19:53:36 -0400
From: KY Srinivasan <kys@microsoft.com>
To: Greg KH <greg@kroah.com>
CC: "gregkh@suse.de" <gregkh@suse.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "virtualization@lists.osdl.org" <virtualization@lists.osdl.org>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        "Abhishek Kane (Mindtree Consulting PVT LTD)" 
	<v-abkane@microsoft.com>,
        "Hank Janssen" <hjanssen@microsoft.com>
Subject: RE: [PATCH 077/206] Staging: hv: Get rid of call to cleanup()
Thread-Topic: [PATCH 077/206] Staging: hv: Get rid of call to cleanup()
Thread-Index: AQHMDpJjVBoLN8VyEUWib/ixs1RrB5SFkAYA//+aVzA=
Date: Mon, 9 May 2011 23:53:35 +0000
Message-ID: <6E21E5352C11B742B20C142EB499E0481EEBA7@TK5EX14MBXC128.redmond.corp.microsoft.com>
References: <1304978242-22958-1-git-send-email-kys@microsoft.com>
 <1304978288-22999-1-git-send-email-kys@microsoft.com>
 <1304978288-22999-77-git-send-email-kys@microsoft.com>
 <20110509225328.GA2832@kroah.com>
In-Reply-To: <20110509225328.GA2832@kroah.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [157.54.51.36]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1948
Lines: 57



> -----Original Message-----
> From: Greg KH [mailto:greg@kroah.com]
> Sent: Monday, May 09, 2011 6:53 PM
> To: KY Srinivasan
> Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang;
> Abhishek Kane (Mindtree Consulting PVT LTD); Hank Janssen
> Subject: Re: [PATCH 077/206] Staging: hv: Get rid of call to cleanup()
> 
> On Mon, May 09, 2011 at 02:55:59PM -0700, K. Y. Srinivasan wrote:
> > cleanup() is an empty function; get rid of it.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
> > Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
> > ---
> >  drivers/staging/hv/netvsc_drv.c |    4 ----
> 
> Just picking a random patch out of this series (which, I only received
> the first 132, not all 206).
> 
> You need to specify a better changelog entry as you didn't say what code
> you are changing in the Subject:.
> 
> How about:
> 	Staging: hv: netvsc_drv: Get rid of call to cleanup()
> 
> Otherwise I would think (and I did) that you got rid of a global
> function called cleanup() in all of the hv code.
> 
> Care to fix the names of your patches?

Good point; I will fix up the names.
> 
> Note, I wouldn't recommend sending that many patches to lkml, it's not
> needed, just stick to the devel@linuxdriverproject.org list as I really
> doubt anyone else cares about this code at the moment.

Agreed; I will do that. Shall I go ahead and fix the names and send the patches 
just to you or do you want me to send them to the devel list as well.

Regards,

K. Y
> 
> thanks,
> 
> greg k-h

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/