Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755759Ab1EJH5f (ORCPT ); Tue, 10 May 2011 03:57:35 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:56297 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752875Ab1EJH5d (ORCPT ); Tue, 10 May 2011 03:57:33 -0400 Date: Tue, 10 May 2011 09:57:27 +0200 (CEST) From: Julia Lawall To: Andy Shevchenko Cc: Vladimir Motyka , cjb@laptop.org, kernel-janitors@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/mmc/card/block.c: fix potential null dereference 'idata' In-Reply-To: Message-ID: References: <4DC7F4AB.90607@gmail.com> <4DC802C0.9040302@gmail.com> <4DC8117C.7060200@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 840 Lines: 24 On Tue, 10 May 2011, Andy Shevchenko wrote: > On Mon, May 9, 2011 at 7:12 PM, Julia Lawall wrote: > > I guess there is also a point at which idata has been successfully > > allocated but idata->buf has not. > And? kfree() simple ignores NULL pointers. Unnecessarily calling a function suggests that calling that function is necessary when it is not. But it is probably not a big deal, especially for a well known function like kfree. julia > I would prefer to see previous version of patch, but let maintainer to choose. > > -- > With Best Regards, > Andy Shevchenko > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/