Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932762Ab1EJIog (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 May 2011 04:44:36 -0400
Received: from mx3.mail.elte.hu ([157.181.1.138]:40988 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756131Ab1EJIoc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 May 2011 04:44:32 -0400
Date: Tue, 10 May 2011 10:44:10 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, David Sharp <dhsharp@google.com>,
        Vaibhav Nagarnaik <vnagarnaik@google.com>,
        Michael Rubin <mrubin@google.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Thomas Gleixner <tglx@linutronix.de>,
        Christoph Hellwig <hch@infradead.org>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: Fix powerTOP regression with 2.6.39-rc5
Message-ID: <20110510084410.GD27426@elte.hu>
References: <1304713252.25414.2532.camel@gandalf.stny.rr.com>
 <BANLkTim9YvResB+PwRp7QTK-a5VNg2PvmQ@mail.gmail.com>
 <20110507065803.GA23414@elte.hu>
 <1304765110.25414.2564.camel@gandalf.stny.rr.com>
 <20110507144402.GC2859@elte.hu>
 <1304788829.11129.57.camel@frodo>
 <20110507190033.GA11465@elte.hu>
 <1304996847.2969.151.camel@frodo>
 <20110510080918.GB27426@elte.hu>
 <4DC8F831.2010404@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4DC8F831.2010404@linux.intel.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
X-ELTE-SpamScore: -2.0
X-ELTE-SpamLevel: 
X-ELTE-SpamCheck: no
X-ELTE-SpamVersion: ELTE 2.0 
X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1
	-2.0 BAYES_00               BODY: Bayes spam probability is 0 to 1%
	[score: 0.0000]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2004
Lines: 50


* Arjan van de Ven <arjan@linux.intel.com> wrote:

> On
> >>name: sched_switch
> >>ID: 57
> >>format:
> >>	field:unsigned short common_type;	offset:0;	size:2;
> >>	field:unsigned char common_flags;	offset:2;	size:1;
> >>	field:unsigned char common_preempt_count;	offset:3;	size:1;
> >>	field:int common_pid;	offset:4;	size:4;
> >>	field:int common_lock_depth;	offset:8;	size:4;
> >>
> >>	field:char prev_comm[TASK_COMM_LEN];	offset:12;	size:16;
> >>	field:pid_t prev_pid;	offset:28;	size:4;
> >>	field:int prev_prio;	offset:32;	size:4;
> >>	field:long prev_state;	offset:40;	size:8;
> >>	field:char next_comm[TASK_COMM_LEN];	offset:48;	size:16;
> >>	field:pid_t next_pid;	offset:64;	size:4;
> >>	field:int next_prio;	offset:68;	size:4;
> >>
> >>Is equivalent to this:
> >>
> >><?xml version="1.0" encoding="UTF-8"?>
> >><KernelShark><CaptureSettings><Events><CaptureType>Events</CaptureType><System>sched</System></Events><Plugin>function_graph</Plugin><File>/tmp/trace.dat</File></CaptureSettings></KernelShark>
> >I did not say that it's equivalent, i said it's XML look-alike.
> >
> >Steve, we even joked about that, that if we continue like this we'll end up
> >with an XML parser ... I requested several changes to the description format so
> >that it becomes more human readable.
> 
> frankly, for software, XML is easier to deal with than the human
> readable form.

Yes, absolutely - still i think keeping it human readable is important.

> if we are serious about wanting software to parse this stuff.. maybe exposing 
> it in an easy to parse format as well is not a bad idea....

Well, the code to parse it intelligently already exists so i dont think we are 
forced to go back to some harder to read (and easier to parse) format.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/