Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752577Ab1EJJTt (ORCPT ); Tue, 10 May 2011 05:19:49 -0400 Received: from mtagate7.uk.ibm.com ([194.196.100.167]:42748 "EHLO mtagate7.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796Ab1EJJTs (ORCPT ); Tue, 10 May 2011 05:19:48 -0400 Date: Tue, 10 May 2011 11:19:26 +0200 From: Martin Schwidefsky To: Robert Richter Cc: Nicolas Kaiser , Heiko Carstens , "linux390@de.ibm.com" , "oprofile-list@lists.sf.net" , "linux-s390@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH resend] s390: oprofile: fix error checks in oprofile_hwsampler_init() Message-ID: <20110510111926.788d7336@mschwide> In-Reply-To: <20110510090054.GS31407@erda.amd.com> References: <20110502154805.71664123@absol.kitzblitz> <20110503085540.GX31407@erda.amd.com> <20110510105510.455bbf5d@mschwide> <20110510090054.GS31407@erda.amd.com> Organization: IBM Corporation X-Mailer: Claws Mail 3.7.9 (GTK+ 2.24.4; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1096 Lines: 36 On Tue, 10 May 2011 11:00:54 +0200 Robert Richter wrote: > > Ok, the improved patch now looks like this: > > -- > > Subject: [PATCH] s390: oprofile: fix min/max interval query checks > > > > From: Martin Schwidefsky > > > > oprofile_min_interval and oprofile_max_interval are unsigned, checking > > for negative values doesn't work. Change hwsampler_query_min_interval > > and hwsampler_query_max_interval to return an unsigned long and > > check for a zero value instead. > > > > Reported-by: Nicolas Kaiser > > Signed-off-by: Martin Schwidefsky > > Looks good. > > Acked-by: Robert Richter > > Martin, can you queue this up? Yes, I will do that. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/