Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932171Ab1EJKIc (ORCPT ); Tue, 10 May 2011 06:08:32 -0400 Received: from ppsw-52.csi.cam.ac.uk ([131.111.8.152]:38654 "EHLO ppsw-52.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752855Ab1EJKIb (ORCPT ); Tue, 10 May 2011 06:08:31 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Message-ID: <4DC90F37.6010000@cam.ac.uk> Date: Tue, 10 May 2011 11:11:03 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20110122 Lightning/1.0b3pre Thunderbird/3.1.7 MIME-Version: 1.0 Newsgroups: gmane.linux.drivers.driver-project.devel,gmane.linux.kernel,gmane.linux.kernel.virtualization To: "K. Y. Srinivasan" CC: gregkh@suse.de, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, virtualization@lists.osdl.org, Haiyang Zhang , Abhishek Kane Subject: Re: [PATCH 005/206] Staging: hv: Rename the device type variable References: <1304978242-22958-1-git-send-email-kys@microsoft.com> <1304978288-22999-1-git-send-email-kys@microsoft.com> <1304978288-22999-5-git-send-email-kys@microsoft.com> In-Reply-To: <1304978288-22999-5-git-send-email-kys@microsoft.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1660 Lines: 43 On 05/09/11 22:54, K. Y. Srinivasan wrote: > Rename the variable g_blk_device_type. Why? A few of these renames could do with a bit more detail on what is wrong with the old names. > > Signed-off-by: K. Y. Srinivasan > Signed-off-by: Haiyang Zhang > Signed-off-by: Abhishek Kane > Signed-off-by: Hank Janssen > --- > drivers/staging/hv/blkvsc_drv.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/hv/blkvsc_drv.c b/drivers/staging/hv/blkvsc_drv.c > index b54130b..51d1265 100644 > --- a/drivers/staging/hv/blkvsc_drv.c > +++ b/drivers/staging/hv/blkvsc_drv.c > @@ -115,7 +115,7 @@ struct block_device_context { > static const char *drv_name = "blkvsc"; > > /* {32412632-86cb-44a2-9b5c-50d1417354f5} */ > -static const struct hv_guid g_blk_device_type = { > +static const struct hv_guid dev_type = { > .data = { > 0x32, 0x26, 0x41, 0x32, 0xcb, 0x86, 0xa2, 0x44, > 0x9b, 0x5c, 0x50, 0xd1, 0x41, 0x73, 0x54, 0xf5 > @@ -178,7 +178,7 @@ static int blk_vsc_initialize(struct hv_driver *driver) > /* Make sure we are at least 2 pages since 1 page is used for control */ > > driver->name = drv_name; > - memcpy(&driver->dev_type, &g_blk_device_type, sizeof(struct hv_guid)); > + memcpy(&driver->dev_type, &dev_type, sizeof(struct hv_guid)); > > > /* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/