Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932578Ab1EJOFs (ORCPT ); Tue, 10 May 2011 10:05:48 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:59121 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932375Ab1EJOFq (ORCPT ); Tue, 10 May 2011 10:05:46 -0400 From: OGAWA Hirofumi To: Jan Kara Cc: "Darrick J. Wong" , Theodore Tso , Alexander Viro , Jens Axboe , "Martin K. Petersen" , Jeff Layton , Dave Chinner , linux-kernel , Dave Hansen , Christoph Hellwig , linux-mm@kvack.org, Chris Mason , Joel Becker , linux-scsi , linux-fsdevel , linux-ext4@vger.kernel.org, Mingming Cao Subject: Re: [PATCHSET v3.1 0/7] data integrity: Stabilize pages during writeback for various fses References: <20110509230318.19566.66202.stgit@elm3c44.beaverton.ibm.com> <87tyd31fkc.fsf@devron.myhome.or.jp> <20110510123819.GB4402@quack.suse.cz> <87hb924s2x.fsf@devron.myhome.or.jp> <20110510132953.GE4402@quack.suse.cz> <878vue4qjb.fsf@devron.myhome.or.jp> Date: Tue, 10 May 2011 23:05:41 +0900 In-Reply-To: <878vue4qjb.fsf@devron.myhome.or.jp> (OGAWA Hirofumi's message of "Tue, 10 May 2011 22:46:16 +0900") Message-ID: <87zkmu3b2i.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1494 Lines: 33 OGAWA Hirofumi writes: > Jan Kara writes: > >>> I see. So many block layer stuff sounds like broken on corner case? If >>> so, I more feel this approach should be temporary workaround, and should >>> use another less-blocking approach. >> Not many but some... The alternative to less blocking approach is to do >> copy-out before a page is submitted for IO (or various middle ground >> alternatives of doing sometimes copyout, sometimes blocking...). That costs >> some performance as well. We talked about it at LSF and the approach >> Darrick is implementing was considered the least intrusive. There's really >> no way to fix these corner cases and keep performance. > > You already considered, to copy only if page was writeback (like > copy-on-write). I.e. if page is on I/O, copy, then switch the page for > writing new data. missed question mark in here. Did you already consider, to copy only if page was writeback (like copy-on-write)? I.e. if page is on I/O, copy, then switch the page for writing new data. > Yes, it is complex. But I think blocking and overhead is minimum, and > this can be used as infrastructure for copy-on-write FS. -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/