Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933017Ab1EJQZ4 (ORCPT ); Tue, 10 May 2011 12:25:56 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:53622 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932828Ab1EJQZy (ORCPT ); Tue, 10 May 2011 12:25:54 -0400 Content-Type: text/plain; charset=UTF-8 From: Chris Mason To: Jan Kara Cc: "Darrick J. Wong" , Theodore Tso , Alexander Viro , OGAWA Hirofumi , Jens Axboe , "Martin K. Petersen" , Jeff Layton , Dave Chinner , linux-kernel , Dave Hansen , Christoph Hellwig , linux-mm , Joel Becker , linux-scsi , linux-fsdevel , linux-ext4 , Mingming Cao Subject: Re: [PATCHSET v3.1 0/7] data integrity: Stabilize pages during writeback for various fses In-reply-to: <20110510125124.GD4402@quack.suse.cz> References: <20110509230318.19566.66202.stgit@elm3c44.beaverton.ibm.com> <20110510125124.GD4402@quack.suse.cz> Date: Tue, 10 May 2011 12:24:50 -0400 Message-Id: <1305044672-sup-6072@shiny> User-Agent: Sup/git Content-Transfer-Encoding: 8bit X-Source-IP: rtcsinet22.oracle.com [66.248.204.30] X-CT-RefId: str=0001.0A090205.4DC966E2.01CC:SCFSTAT5015188,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1282 Lines: 23 Excerpts from Jan Kara's message of 2011-05-10 08:51:24 -0400: > On Mon 09-05-11 16:03:18, Darrick J. Wong wrote: > > I am still chasing down what exactly is broken in ext3. data=writeback mode > > passes with no failures. data=ordered, however, does not pass; my current > > suspicion is that jbd is calling submit_bh on data buffers but doesn't call > > page_mkclean to kick the userspace programs off the page before writing it. > Yes, ext3 in data=ordered mode writes pages from > journal_commit_transaction() via submit_bh() without clearing page dirty > bits thus page_mkclean() is not called for these pages. Frankly, do you > really want to bother with adding support for ext2 and ext3? People can use > ext4 as a fs driver when they want to start using blk-integrity support. > Especially ext2 patch looks really painful and just from a quick look I can > see code e.g. in fs/ext2/namei.c which isn't handled by your patch yet. I think ext23 are going to be pretty big changes, we're best off just going with ext4. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/