Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752054Ab1EJRDQ (ORCPT ); Tue, 10 May 2011 13:03:16 -0400 Received: from cantor.suse.de ([195.135.220.2]:43305 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750929Ab1EJRDO (ORCPT ); Tue, 10 May 2011 13:03:14 -0400 Date: Tue, 10 May 2011 19:03:07 +0200 From: Jan Kara To: OGAWA Hirofumi Cc: Jan Kara , Christoph Hellwig , "Darrick J. Wong" , Theodore Tso , Alexander Viro , Jens Axboe , "Martin K. Petersen" , Jeff Layton , Dave Chinner , linux-kernel , Dave Hansen , linux-mm@kvack.org, Chris Mason , Joel Becker , linux-scsi , linux-fsdevel , linux-ext4@vger.kernel.org, Mingming Cao Subject: Re: [PATCHSET v3.1 0/7] data integrity: Stabilize pages during writeback for various fses Message-ID: <20110510170307.GO4402@quack.suse.cz> References: <20110509230318.19566.66202.stgit@elm3c44.beaverton.ibm.com> <87tyd31fkc.fsf@devron.myhome.or.jp> <20110510133603.GA5823@infradead.org> <874o524q9h.fsf@devron.myhome.or.jp> <20110510144939.GI4402@quack.suse.cz> <87aaeur31x.fsf@devron.myhome.or.jp> <20110510161836.GL4402@quack.suse.cz> <87r586plhz.fsf@devron.myhome.or.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r586plhz.fsf@devron.myhome.or.jp> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1040 Lines: 28 On Wed 11-05-11 01:29:28, OGAWA Hirofumi wrote: > Jan Kara writes: > > > On Wed 11-05-11 00:24:58, OGAWA Hirofumi wrote: > >> Jan Kara writes: > >> > >> >> Isn't it reallocated blocks too, and metadata too? > >> > Reallocated blocks - not really. For a block to be freed it cannot be > >> > under writeback and when it's freed no writeback is started. > >> > >> Sure for data -> data reallocated case. metadata -> data/metadata is > >> still there. > > Unless you properly use bforget() (which you should I think). But I have > > not really checked this in detail for a while. > > bforget() doesn't wait IO, right? Right, my fault. Sorry. So you were right, reallocated blocks will be hit as well. Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/