Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753461Ab1EJX3I (ORCPT ); Tue, 10 May 2011 19:29:08 -0400 Received: from smtp-out.google.com ([216.239.44.51]:9868 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753419Ab1EJX3G (ORCPT ); Tue, 10 May 2011 19:29:06 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; b=p/ngTETCcYEe0q948UjlYz5/5OKMASyHgH5a1oHF1ukU8x5ZCgWxCYGTBHxGJfGDO8 C8oU70DdaSbAkeSzAA5w== Date: Tue, 10 May 2011 16:29:02 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: KOSAKI Motohiro cc: CAI Qian , avagin@gmail.com, Andrey Vagin , Andrew Morton , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim , Hugh Dickins , Oleg Nesterov Subject: Re: [PATCH 1/4] oom: improve dump_tasks() show items In-Reply-To: <20110510171600.16AB.A69D9226@jp.fujitsu.com> Message-ID: References: <20110509182110.167F.A69D9226@jp.fujitsu.com> <20110510171335.16A7.A69D9226@jp.fujitsu.com> <20110510171600.16AB.A69D9226@jp.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2952 Lines: 83 On Tue, 10 May 2011, KOSAKI Motohiro wrote: > Recently, oom internal logic was dramatically changed. Thus > dump_tasks() is no longer useful. it has some meaningless > items and don't have some oom socre related items. > This changelog is inaccurate. dump_tasks() is actually useful as it currently stands; there are things that you may add or remove but saying that it is "no longer useful" is an exaggeration. > This patch adapt displaying fields to new oom logic. > > details > ========== > removed: pid (we always kill process. don't need thread id), > mm->total_vm (we no longer uses virtual memory size) Showing mm->total_vm is still interesting to know what the old heuristic would have used rather than the new heuristic, I'd prefer if we kept it. > signal->oom_adj (we no longer uses it internally) > added: ppid (we often kill sacrifice child process) > modify: RSS (account mm->nr_ptes too) I'd prefer if ptes were shown independently from rss instead of adding it to the thread's true rss usage and representing it as such. I think the cpu should also be removed. For the next version, could you show the old output and comparsion to new output in the changelog? > > Signed-off-by: KOSAKI Motohiro > --- > > Strictly speaking. this is NOT a part of oom fixing patches. but it's > necessary when I parse QAI's test result. > > > mm/oom_kill.c | 14 ++++++++------ > 1 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index f52e85c..118d958 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -355,7 +355,7 @@ static void dump_tasks(const struct mem_cgroup *mem, const nodemask_t *nodemask) > struct task_struct *p; > struct task_struct *task; > > - pr_info("[ pid ] uid tgid total_vm rss cpu oom_adj oom_score_adj name\n"); > + pr_info("[ pid] ppid uid rss cpu score_adj name\n"); > for_each_process(p) { > if (oom_unkillable_task(p, mem, nodemask)) > continue; > @@ -370,11 +370,13 @@ static void dump_tasks(const struct mem_cgroup *mem, const nodemask_t *nodemask) > continue; > } > > - pr_info("[%5d] %5d %5d %8lu %8lu %3u %3d %5d %s\n", > - task->pid, task_uid(task), task->tgid, > - task->mm->total_vm, get_mm_rss(task->mm), > - task_cpu(task), task->signal->oom_adj, > - task->signal->oom_score_adj, task->comm); > + pr_info("[%6d] %6d %5d %8lu %4u %9d %s\n", > + task_tgid_nr(task), task_tgid_nr(task->real_parent), > + task_uid(task), > + get_mm_rss(task->mm) + p->mm->nr_ptes, > + task_cpu(task), > + task->signal->oom_score_adj, > + task->comm); > task_unlock(task); > } > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/