Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756281Ab1EKP5g (ORCPT ); Wed, 11 May 2011 11:57:36 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:36367 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754620Ab1EKP5d convert rfc822-to-8bit (ORCPT ); Wed, 11 May 2011 11:57:33 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=jm2q65llkPH9W3XLpqbH8wzQ54tJYvVkQwBM/vETucZ4rV8B4JjXhyEiLgiYmAISV+ 3yZdDtYwCB0nvzjG4JCmVgZ3/J+kfs7aJbncFPtHS6AgaSZY0Ih6orpaus2KQbzvznHJ RTBdKEj7rdF1/eGJnTqVl7prdYY+LtNMPxR1I= MIME-Version: 1.0 In-Reply-To: <20110510161137.GA14522@kroah.com> References: <5C4C569E8A4B9B42A84A977CF070A35B2C16FB4712@USINDEVS01.corp.hds.com> <20110510161137.GA14522@kroah.com> Date: Wed, 11 May 2011 21:09:26 +0800 Message-ID: Subject: Re: [RFC][PATCH] pstore: EFI Support From: =?UTF-8?Q?Am=C3=A9rico_Wang?= To: Greg KH Cc: Seiji Aguchi , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "Luck, Tony" , "hpa@zytor.com" , "mikew@google.com" , "a.p.zijlstra@chello.nl" , Andrew Morton , "tj@kernel.org" , "fweisbec@gmail.com" , "dle-develop@lists.sourceforge.net" , Satoru Moriya Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 25 On Wed, May 11, 2011 at 12:11 AM, Greg KH wrote: > On Tue, May 10, 2011 at 11:00:44AM -0400, Seiji Aguchi wrote: >> Description of boot paremeters is following. >> >>  - efi_pstore_enable >>    enable EFI support of pstore. >> >>  - efi_pstore_len >>    Sets the buffer size of EFI variable space used by pstore. > > Please don't add new boot parameters if at all possible.  Distros will > not know to enable them, and users don't know how to either. > > Use sane defaults, and provide ways to override them if needed, but > don't rely on them for new functionality if at all possible. I agree. It seems that we should enable this by default when APEI and EFI are both enabled, this could be done by Kconfig. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/