Date: Wed, 11 May 2011 06:51:14 -0700
From: Greg KH <greg@kroah.com>
To: Jason Stubbs <jasonbstubbs@gmail.com>
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform: fix samsung brightness min/max calculations
Message-ID: <20110511135114.GD12717@kroah.com>
References: <201104201358.50443.jasonbstubbs@gmail.com>
 <201104281855.50572.jasonbstubbs@gmail.com>
 <20110510223908.GA16989@kroah.com>
 <201105111447.49816.jasonbstubbs@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201105111447.49816.jasonbstubbs@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1411
Lines: 34

On Wed, May 11, 2011 at 02:47:49PM +1000, Jason Stubbs wrote:
> On Wed, 11 May 2011 08:39:08 Greg KH wrote:
> > On Thu, Apr 28, 2011 at 06:55:50PM +1000, Jason Stubbs wrote:
> > > Not sure of the "bump" process, so I'll just go over each part of the
> > > patch.
> > > 
> > > Note that all the changes only affect the sabi_config where
> > > min_brightness is 1 so you might not see in difference on your hardware.
> > 
> > This isn't needed anymore due to your other patch superseeding it,
> > right?
> 
> Actually, this one is irrelevant to the nc210/nc110 support as that laptop 
> uses the "SwSmi@" sabi. It was just something I noticed while learning the 
> code. The miscalculations will only affect any laptops that use the "SECLINUX" 
> sabi but I tested it by setting min_brightness to 2 for my laptop.

That's wierd, as that is the type of laptop I have here and it seems to
work just fine for me as-is.

> The patch doesn't apply cleanly on top of the nc210/nc110 patch though as they 
> both modify set_brightness(). It might apply with a higher fuzz factor as the 
> changes don't actually clash. Should I redo the patch?

Please do.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/