Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756715Ab1EKP7U (ORCPT ); Wed, 11 May 2011 11:59:20 -0400 Received: from casper.infradead.org ([85.118.1.10]:54156 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756692Ab1EKP7H (ORCPT ); Wed, 11 May 2011 11:59:07 -0400 Subject: Re: [PATCH] sched: fix constructing the span cpu mask of sched domain From: Peter Zijlstra To: Hillf Danton Cc: LKML , Ingo Molnar , Mike Galbraith , Yong Zhang , Andreas Herrmann In-Reply-To: References: <1305016329.2914.22.camel@laptop> Content-Type: text/plain; charset="UTF-8" Date: Wed, 11 May 2011 15:54:15 +0200 Message-ID: <1305122055.2914.220.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1056 Lines: 24 On Wed, 2011-05-11 at 21:26 +0800, Hillf Danton wrote: > Your work for rewriting NUMA support, published at > http://marc.info/?l=linux-kernel&m=130218515520540 > is patched by changing how level is computed and by changing how it is > used to build the mask. > > When computing, some valid levels are lost in your work. > > When building mask, nodes are selected only if they have same distance, > thus nodes of less distance are also masked out since the computation of > level now is tough. > > Without MUNA hardware, I did not test the patch:( I do have a (tiny) NUMA box (2 nodes) but that actually booted with the old code too, Andreas Hermann from AMD (CC'ed) is usually willing to test such patches on somewhat larger systems. Please send a full patch against tip/master for him to apply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/