DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=pr+s74ejPPaRkvA0XTmB8xA7G5FKWUMQicZxSd3drlJTW7CALF2WYJTWFmecc2nvMK
         x4mLpLezLazJkuug/4dgMBrNbke1gt24ZtnOSyh6L8J25jljjhY9z+2XDcHzKYCBxSEL
         q8bAPUwEdRDUM0HS17zGviMFcIJ14nH8zQAis=
Date: Wed, 11 May 2011 14:12:38 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Steven Liu <lingjiujianke@gmail.com>
Cc: jy0922.shim@samsung.com, linux-kernel@vger.kernel.org,
        linux-input@vger.kernel.org, liuqi@thunderst.com
Subject: Re: [PATCH] touchscreen: check kzalloc memory for data first
Message-ID: <20110511211238.GA11178@core.coreip.homeip.net>
References: <BANLkTi=yWrPiz9Wp0H46at4NVfMSJ8n1uw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BANLkTi=yWrPiz9Wp0H46at4NVfMSJ8n1uw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 914
Lines: 27

Hi Steven,

On Wed, May 11, 2011 at 10:23:16AM +0800, Steven Liu wrote:
> Hi Joonyoung Shim ,
> 
>             Can this patch be fixed in?
> 
> 
> if kzalloc memroy for data was faild, it will multi free data
> memory space. so check the data memory first, is it kzalloc faild
> for data, it should goto end and do nothing.

There is no double-free as both kfree() and input_free_device() know to
ignore NULL pointers and we ensure that both pointers to be initialized
(either point to allocated memory or be NULL). We do not expect either
of the memory allocations to fail so instead of handling failures
separately they are handled both at once.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/