Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756781Ab1EKVyj (ORCPT ); Wed, 11 May 2011 17:54:39 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:44451 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752805Ab1EKVyi (ORCPT ); Wed, 11 May 2011 17:54:38 -0400 Date: Wed, 11 May 2011 22:55:57 +0100 From: Alan Cox To: Patrik Jakobsson Cc: alan@linux.intel.com, greg@kroah.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gma500: Skip bogus LVDS VBT mode and check for LVDS before adding backlight (try 2) Message-ID: <20110511225557.2c8f6649@lxorguk.ukuu.org.uk> In-Reply-To: <20110511204609.GA6059@patrik-macbook> References: <20110511204609.GA6059@patrik-macbook> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 729 Lines: 18 On Wed, 11 May 2011 22:46:09 +0200 Patrik Jakobsson wrote: > On the Fit-PC2 the VBT reports an invalid fixed panel mode for LVDS, this gets > in the way for SDVO. This patch makes VBT parsing skip the invalid mode. When > there is no LVDS output the backlight support crashes so the patch also checks > for this before enabling it. > > Signed-off-by: Patrik Jakobsson Looks good to me. I'll add that to the pile. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/