DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=xenotime.net;
	h=Received:Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:Organization:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User;
	b=bqKv0Pv3DgGsvMysbhSkWPDzdt5N23tf0Wz6ZGzQpAg1HTLBqp9CwlbERlr9LtwJqGbDPXDZeZnIhBGsaU6VDi3it8o65DoUirlmgEhRJNNQP1G7mdDUC0FYiGmRSnXv;
Date: Wed, 11 May 2011 18:07:11 -0700
From: Randy Dunlap <rdunlap@xenotime.net>
To: Mark Salter <msalter@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/c6x: new architecture port for linux
Message-Id: <20110511180711.6be689bd.rdunlap@xenotime.net>
In-Reply-To: <1305161873.15167.78.camel@deneb.localdomain>
References: <1305144843-5058-1-git-send-email-msalter@redhat.com>
	<20110511143442.7c163a74.rdunlap@xenotime.net>
	<1305161873.15167.78.camel@deneb.localdomain>
Organization: YPO4
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1169
Lines: 27

On Wed, 11 May 2011 20:57:53 -0400 Mark Salter wrote:

> On Wed, 2011-05-11 at 14:34 -0700, Randy Dunlap wrote:
> > Please run the patches thru checkpatch.pl.  You don't have to fix
> > everything that it whines about, just use good judgment.
> 
> Thanks Randy.
> 
> Was there anything particular that jumped out at you. I did run
> checkpatch and there were 7 seven errors but none seemed fixable to
> me (unless there really is a way to get rid of kernel_thread). The
> warnings were almost all about exceeded 80 char line width. I have
> been working on those for a while and there's a lot less than there
> used to be! :-)

There was one in drivers/platform/c6x/ where a driver included asm/timer.h
instead of linux/timer.h (IIRC - I don't have the patch handy ATM to run it
again).  checkpatch said to use linux/ instead of asm/.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/