Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754018Ab1ELHwu (ORCPT ); Thu, 12 May 2011 03:52:50 -0400 Received: from mail-qy0-f181.google.com ([209.85.216.181]:61546 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476Ab1ELHwr convert rfc822-to-8bit (ORCPT ); Thu, 12 May 2011 03:52:47 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=wILzLU6oQWvzygasP9Z14+5zeMg61YzqJXPhR4OOTsLgB6F6nBDzbZj4PfNMyuEkgg mQrL3p+q2zJ22R9HtdjCfAggjtl1/+hvvrasmLLB2x+IW99kjJSleMOe/ovnhzYFp8nk 8O32KXekz9uBOXZE5blMsVdyV2JMmPsg2/mU0= MIME-Version: 1.0 In-Reply-To: References: <4DA4B6A8.7030804@gmail.com> <87tydu3t4p.fsf_-_@tucsk.pomaz.szeredi.hu> From: Michal Suchanek Date: Thu, 12 May 2011 09:52:27 +0200 X-Google-Sender-Auth: 0XTyTlSwPIpMLQjqjoPxiI8tNYA Message-ID: Subject: Re: [PATCH] tmpfs: implement generic xattr support To: Hugh Dickins Cc: Miklos Szeredi , Andreas Dilger , Jiri Kosina , Ric Wheeler , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, David Howells , Ian Kent , Jeff Moyer , Christoph Hellwig , Eric Paris , Andrew Morton , James Morris , Serge Hallyn Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2013 Lines: 48 On 12 May 2011 06:20, Hugh Dickins wrote: > On Tue, 19 Apr 2011, Miklos Szeredi wrote: ... > > I disagree with Andrew on this, it should default to off, consistent with > the "If unsure, say N" comment.  Partly because that's how Linus prefers > it, for good anti-bloat reasons: if people have got along without a > feature for years, whyever should we suddenly default it on?  And > partly because TMPFS_POSIX_ACL already defaults to off (as do > EXT2_FS_XATTR and EXT2_FS_POSIX_ACL). > > However... if someone already has CONFIG_TMPFS_POSIX_ACL=y in their > old config, it would be nice to make CONFIG_TMPFS_XATTR=y automatically, > so we're not in danger of removing their old functionality.  But I haven't > thought of the right way to achieve that - maybe your helpful POSIX ACL > comment is enough, but automatic would be better. > > Few people would choose TMPFS_XATTR on and TMPFS_POSIX_ACL off: perhaps it > would work to make CONFIG_TMPFS_XATTR the new config option to cover both, > and select it from config TMPFS_POSIX_ACL (without a prompt) so the > oldconfig propagates correctly.  Perhaps.  But I haven't tried myself, > and you may be forgiveably disinclined to make config experiments! The xattrs are required for overlayfs so "generic" kernels will probably want those. However, the "generic" kernels likely have the acls already so this is not that much of an issue. Perhaps the acls should select xattrs so that in configs that had acls the xattrs are added automagically. Or does it already work with depends? Thanks Michal > >>  config TMPFS_POSIX_ACL >>       bool "Tmpfs POSIX Access Control Lists" >> -     depends on TMPFS >> +     depends on TMPFS_XATTR >>       select GENERIC_ACL >>       help -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/