Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752718Ab1ELLDg (ORCPT ); Thu, 12 May 2011 07:03:36 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:59645 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738Ab1ELLDf (ORCPT ); Thu, 12 May 2011 07:03:35 -0400 Date: Thu, 12 May 2011 13:03:21 +0200 From: Ingo Molnar To: Borislav Petkov Cc: Peter Zijlstra , Frederic Weisbecker , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH] perf: Carve out cgroup-related code Message-ID: <20110512110321.GO9937@elte.hu> References: <20110511121135.GA25865@aftab> <1305121600.2914.214.camel@laptop> <20110511140208.GD25827@aftab> <20110511141342.GA19053@elte.hu> <20110511143149.GA26548@aftab> <20110511152156.GA21707@elte.hu> <20110511170912.GA27362@aftab> <20110512103644.GH9937@elte.hu> <20110512105421.GC17731@aftab> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110512105421.GC17731@aftab> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1248 Lines: 43 * Borislav Petkov wrote: > On Thu, May 12, 2011 at 06:36:44AM -0400, Ingo Molnar wrote: > > > > * Borislav Petkov wrote: > > > > > Done, patch below. I've moved all exports local to kernel/events/* to > > > internal.h. Branch at > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git perf-split > > > > Beyond the things Peter noticed, there's also this new bit in perf_event.h: > > > > enum event_type_t { > > EVENT_FLEXIBLE = 0x1, > > EVENT_PINNED = 0x2, > > EVENT_ALL = EVENT_FLEXIBLE | EVENT_PINNED, > > }; > > > > this got there from core.c, albeit it's only core.c that uses it. > > > > If then this should move to internal.h - or stay local to core.c. > > event_type_t gets pulled by pushing > > ctx_sched_out(..., enum event_type_t event_type) > > up into the header since otherwise gcc complains of not seeing the > definition of the third argument. > > And yes, it should go to internal.h. yeah. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/