Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756493Ab1ELL4D (ORCPT ); Thu, 12 May 2011 07:56:03 -0400 Received: from eu1sys200aog118.obsmtp.com ([207.126.144.145]:58648 "EHLO eu1sys200aog118.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756120Ab1ELL4A (ORCPT ); Thu, 12 May 2011 07:56:00 -0400 From: Par-Gunnar HJALMDAHL To: Greg KH Cc: Greg Kroah-Hartman , "devel@driverdev.osuosl.org" , Linus Walleij , "linux-kernel@vger.kernel.org" , "linux-bluetooth@vger.kernel.org" , Pavan Savoy , Vitaly Wool , Alan Cox , Arnd Bergmann , Marcel Holtmann , Lukasz Rymanowski , Linus WALLEIJ , Par-Gunnar Hjalmdahl , Lee Jones , Mathieu Poirier Date: Thu, 12 May 2011 13:54:46 +0200 Subject: RE: [PATCH v6] staging: Add ST-Ericsson CG2900 driver Thread-Topic: [PATCH v6] staging: Add ST-Ericsson CG2900 driver Thread-Index: AcwP4r5iTiZzbKiLTzOXKzxYPLLQJAAt3uGA Message-ID: References: <1305040232-750-1-git-send-email-par-gunnar.p.hjalmdahl@stericsson.com> <20110510200801.GA8125@kroah.com> <20110511134859.GB12717@kroah.com> In-Reply-To: <20110511134859.GB12717@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id p4CBu8rs008016 Content-Length: 1437 Lines: 40 > -----Original Message----- > From: Greg KH [mailto:greg@kroah.com] > Sent: den 11 maj 2011 15:49 > > > I used next-20110510 and in that tag the file > include/Linux/mfd/core.h > > The struct mfd_cell has a parameter called platform_data, while in > your > > build it seems it doesn't. > > This was changed very recently in the core.h file (on April 6). > > So for core.h the last commit ID I have in the tag I built upon is > > 558aa9c0d620b91a896d5e39ce8a570bed65589b. > > So do I need that patch on the staging-next tree also? > > Or is it an issue of building this on x86-64... > > thanks, > > greg k-h Hi Greg, I downloaded you staging tree and compared the logs for the core.h file. Compared to linux-next tag next-20110510 it is missing 2 commits: 4dbee6b76fffd5740e87e286f4f4c1c15901bcae 558aa9c0d620b91a896d5e39ce8a570bed65589b where the first one is the "oldest" one in the log and is the most important one for my patch. Another option would be for me to fix the patch for your tree, but then I would probably have to fix it back in a few days when you update your staging tree to Linux-next. How often is your tree updated? The easiest is probably to wait a few days until you have the next-20110510 tag in your tree and then apply the patch. Thanks, P-G ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?