Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757805Ab1ELOpp (ORCPT ); Thu, 12 May 2011 10:45:45 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:36744 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754158Ab1ELOpn (ORCPT ); Thu, 12 May 2011 10:45:43 -0400 Date: Thu, 12 May 2011 10:45:43 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Tanya Brokhman cc: "'Sebastian Andrzej Siewior'" , , , , , , "'open list'" Subject: RE: [PATCH v9 7/7] usb: Adding SuperSpeed support to dummy_hcd In-Reply-To: <000b01cc1064$3b7e51d0$b27af570$@org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 26 On Thu, 12 May 2011, Tanya Brokhman wrote: > > >+ retval = usb_add_hcd(hs_hcd, 0, IRQF_DISABLED | IRQF_SHARED); > > Why IRQF_DISABLED | IRQF_SHARED? you don't interrupts at all. > > I used xhci as reference for this patch. This is the way xhci driver adds > the hcds. You can find it in xhci_pci_probe(). > I'm not very familiar with how this two hcds (main and shared shcd) will > work together so I thought these flags are needed for their co-operation. > Was my assumption mistaken? What flags should I use? You don't need any flags at all, because dummy-hcd does not handle any hardware interrupts. > Also, Sergei pointed out that IRQF_DISABLED is deprecated so it seems to me > that xhci needs an update as well.... Plus every other source file that uses IRQF_DISABLED... Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/