Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754200Ab1EMDQc (ORCPT ); Thu, 12 May 2011 23:16:32 -0400 Received: from mail-qy0-f181.google.com ([209.85.216.181]:41354 "EHLO mail-qy0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911Ab1EMDQb (ORCPT ); Thu, 12 May 2011 23:16:31 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=WrxeBvAYJpl4SJgAHYH8vtbLmemzOEqkfVn0/52z6tGpryHD22u3DSD4pBrLgw8AB1 uVqu4GJeqQVfJJUU1xy6NAvkBqs4J63XAXo+3kgFJalbLslezu9DVUR/6q9DtMoK3G3w fGPHgLxRLKmFJvo+HbErBfozlOGXnkaVyIMaU= MIME-Version: 1.0 In-Reply-To: <69e8f8a9-4e8b-4c02-b566-304ff837d166@email.android.com> References: <1305248699-2347-1-git-send-email-daniel.blueman@gmail.com> <69e8f8a9-4e8b-4c02-b566-304ff837d166@email.android.com> Date: Fri, 13 May 2011 11:16:30 +0800 Message-ID: Subject: Re: [PATCH] x86: Add Dell E5420 reboot quirk From: Daniel J Blueman To: "H. Peter Anvin" Cc: Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1641 Lines: 35 On 13 May 2011 10:44, H. Peter Anvin wrote: > Daniel J Blueman wrote: >> Rebooting on the Dell E5420 often hangs with the keyboard method, but is >> reliable via the PCI method. Signed-off-by: Daniel J Blueman >> --- arch/x86/kernel/reboot.c | 8 ++++++++ 1 files >> changed, 8 insertions(+), 0 deletions(-) diff --git >> a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index 08c44b0..b16032d >> 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c @@ >> -411,6 +411,14 @@ static struct dmi_system_id __initdata >> pci_reboot_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "iMac9,1"), }, }, + { >> + .callback = set_pci_reboot, + .ident = "Dell Latitude E5420", + .matches = >> { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, >> "Latitude E5420"), + }, + }, { } }; -- 1.7.4.1 > How does it work with ACPI? All other reboot methods including ACPI are unreliable and seem to demonstrate the same failure probability; PCI is the only reliable method alas. I guess the ACPI reboot method is the supported 'official' vector (and is what Windows uses [1]), so there must be some other constraints preventing it work as expected, unless the ACPI tables delivered to Linux are broken, would you say? Daniel [1] http://comments.gmane.org/gmane.linux.kernel/1122388 -- Daniel J Blueman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/