Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758100Ab1EMIa3 (ORCPT ); Fri, 13 May 2011 04:30:29 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:49007 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758029Ab1EMIa1 (ORCPT ); Fri, 13 May 2011 04:30:27 -0400 Date: Fri, 13 May 2011 10:30:13 +0200 From: Ingo Molnar To: Jean-Christophe PLAGNIOL-VILLARD Cc: Michal Marek , Arnaud Lacombe , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, x86@kernel.org, Ingo Molnar Subject: Re: [PATCH v2] kconfig: autogenerated config_is_xxx macro Message-ID: <20110513083013.GC13647@elte.hu> References: <1304658229-30820-1-git-send-email-plagnioj@jcrosoft.com> <20110507015041.GA21017@game.jcrosoft.org> <4DC7AB57.9050002@suse.cz> <20110513080909.GO18952@game.jcrosoft.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110513080909.GO18952@game.jcrosoft.org> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 518 Lines: 19 * Jean-Christophe PLAGNIOL-VILLARD wrote: > -#ifdef CONFIG_PCI_BIOS > - if (!rt->signature) { > + if (config_is_pci_bios() && !rt->signature) { Makes sense - but please name it in a more obvious way, such as: pci_bios_enabled() Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/