Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758172Ab1EMIrw (ORCPT ); Fri, 13 May 2011 04:47:52 -0400 Received: from 64.mail-out.ovh.net ([91.121.185.65]:45246 "HELO 64.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1758113Ab1EMIru (ORCPT ); Fri, 13 May 2011 04:47:50 -0400 Date: Fri, 13 May 2011 10:36:52 +0200 From: Jean-Christophe PLAGNIOL-VILLARD To: Ingo Molnar Cc: Michal Marek , Arnaud Lacombe , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, x86@kernel.org, Ingo Molnar Subject: Re: [PATCH v2] kconfig: autogenerated config_is_xxx macro Message-ID: <20110513083652.GP18952@game.jcrosoft.org> References: <1304658229-30820-1-git-send-email-plagnioj@jcrosoft.com> <20110507015041.GA21017@game.jcrosoft.org> <4DC7AB57.9050002@suse.cz> <20110513080909.GO18952@game.jcrosoft.org> <20110513083013.GC13647@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110513083013.GC13647@elte.hu> X-PGP-Key: http://uboot.jcrosoft.org/plagnioj.asc X-PGP-key-fingerprint: 6309 2BBA 16C8 3A07 1772 CC24 DEFC FFA3 279C CE7C User-Agent: Mutt/1.5.20 (2009-06-14) X-Ovh-Tracer-Id: 17308177793985915888 X-Ovh-Remote: 213.251.161.87 (ns32433.ovh.net) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-Spam-Check: DONE|U 0.5/N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 33 On 10:30 Fri 13 May , Ingo Molnar wrote: > > * Jean-Christophe PLAGNIOL-VILLARD wrote: > > > -#ifdef CONFIG_PCI_BIOS > > - if (!rt->signature) { > > + if (config_is_pci_bios() && !rt->signature) { > > Makes sense - but please name it in a more obvious way, such as: > > pci_bios_enabled() the idea to generate the macro via Kconfig so I propose config_is_pci_bios() and if it's a module config_is_pci_bios_module() if you have a better convention naming I'm fine to change it maybe config_pci_bios_enabled() / config_pci_bios_module_enabled or pci_bios_enabled() / pci_bios_module_enabled() Best Regards, J. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/