DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=OjVFRMW1wijgDzChTbsOxZIOx/qWbL/UwS8sTy/hJhjSyP+ZN7yuAFWIpOOkOqgTck
         +NcXTOOU2Id7yjtROn5EkKaLdBK8I9qZP+l14unwDJxh961VByH/peO/A0gFd/cpe6Iy
         ravAn5k7X2/4sb5JTxBHQY+hHhPVCyb/vACsg=
MIME-Version: 1.0
In-Reply-To: <20110513100152.GN13647@elte.hu>
References: <1304658229-30820-1-git-send-email-plagnioj@jcrosoft.com>
	<BANLkTi=s8w01NHnxB7cfCvy4ZS5GnUABZg@mail.gmail.com>
	<20110507015041.GA21017@game.jcrosoft.org>
	<4DC7AB57.9050002@suse.cz>
	<20110513080909.GO18952@game.jcrosoft.org>
	<20110513083013.GC13647@elte.hu>
	<20110513083652.GP18952@game.jcrosoft.org>
	<20110513100152.GN13647@elte.hu>
Date: Fri, 13 May 2011 13:21:27 +0300
Message-ID: <BANLkTikXCQd+DaSD6o5Xdakk760wBTDq=Q@mail.gmail.com>
Subject: Re: [PATCH v2] kconfig: autogenerated config_is_xxx macro
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
        Michal Marek <mmarek@suse.cz>, Arnaud Lacombe <lacombar@gmail.com>,
        linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
        x86@kernel.org, Ingo Molnar <mingo@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1514
Lines: 44

On Fri, May 13, 2011 at 1:01 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
>
>> On 10:30 Fri 13 May ? ? , Ingo Molnar wrote:
>> >
>> > * Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
>> >
>> > > -#ifdef CONFIG_PCI_BIOS
>> > > - if (!rt->signature) {
>> > > + if (config_is_pci_bios() && !rt->signature) {
>> >
>> > Makes sense - but please name it in a more obvious way, such as:
>> >
>> > ? ? pci_bios_enabled()
>> the idea to generate the macro via Kconfig
>
> Okay, and there we are stuck with whatever the Kconfig name is. (we could
> rename that but not needed really)
>
> Why not the canonical config_pci_bios() variant? It's the shortest one to
> write. The '_is' looks pretty superfluous to me.
>
> Hm, i guess it could be mixed up with a function that configures the pci_bios.
>
> I guess since i don't have any better idea config_is_pci_bios() sounds like a
> good choice after all.

But we don't name config options like CONFIG_IS_PCI_BIOS, do we?
One should lowercase config option to minimize confusion, nothing more
if lowercased variant is OK.

Why it looks like a function call?

In fact one can even do

    if (CONFIG_PCI_BIOS && !rt->signature) {

for boolean options.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/