Date: Fri, 13 May 2011 14:21:12 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
        Michal Marek <mmarek@suse.cz>, Arnaud Lacombe <lacombar@gmail.com>,
        linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
        x86@kernel.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v2] kconfig: autogenerated config_is_xxx macro
Message-ID: <20110513122112.GA469@elte.hu>
References: <1304658229-30820-1-git-send-email-plagnioj@jcrosoft.com>
 <BANLkTi=s8w01NHnxB7cfCvy4ZS5GnUABZg@mail.gmail.com>
 <20110507015041.GA21017@game.jcrosoft.org>
 <4DC7AB57.9050002@suse.cz>
 <20110513080909.GO18952@game.jcrosoft.org>
 <20110513083013.GC13647@elte.hu>
 <20110513083652.GP18952@game.jcrosoft.org>
 <20110513100152.GN13647@elte.hu>
 <BANLkTikXCQd+DaSD6o5Xdakk760wBTDq=Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <BANLkTikXCQd+DaSD6o5Xdakk760wBTDq=Q@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1592
Lines: 46


* Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Fri, May 13, 2011 at 1:01 PM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> >
> >> On 10:30 Fri 13 May ? ? , Ingo Molnar wrote:
> >> >
> >> > * Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> >> >
> >> > > -#ifdef CONFIG_PCI_BIOS
> >> > > - if (!rt->signature) {
> >> > > + if (config_is_pci_bios() && !rt->signature) {
> >> >
> >> > Makes sense - but please name it in a more obvious way, such as:
> >> >
> >> > ? ? pci_bios_enabled()
> >> the idea to generate the macro via Kconfig
> >
> > Okay, and there we are stuck with whatever the Kconfig name is. (we could
> > rename that but not needed really)
> >
> > Why not the canonical config_pci_bios() variant? It's the shortest one to
> > write. The '_is' looks pretty superfluous to me.
> >
> > Hm, i guess it could be mixed up with a function that configures the pci_bios.
> >
> > I guess since i don't have any better idea config_is_pci_bios() sounds like a
> > good choice after all.
> 
> But we don't name config options like CONFIG_IS_PCI_BIOS, do we?

The problem is that 'config' can be misunderstood as a verb - it's often used 
for function names to say 'to configure'.

By naming it 'config_is_()' it unambiguously becomes a noun.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/