DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:mime-version:content-type
         :content-disposition:user-agent;
        b=v2n8m57jFBCBv62fF8QEfa6gW2bDPrR+sji6yT396QdCq6PDyfdeZD68fG1yctZOb1
         6V/vGMYXcTmZjz96xKwpwOS6mjqoPJAei/0YsVtvc9EIXFa72/i8dvsSXHwKRL4M2l52
         EyndT0HvzQS7tKxztBcsNHE8xfXfMq5Ii2vJg=
Date: Sat, 14 May 2011 16:43:07 +0300
From: Maxin B John <maxin.john@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kaber@trash.net, yoshfuji@linux-ipv6.org,
        jmorris@namei.org, pekkas@netcore.fi, kuznet@ms2.inr.ac.ru,
        davem@davemloft.net
Subject: [PATCH] net: ipv6: mcast: Removing invalid check
Message-ID: <20110514134307.GA3603@maxin>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 882
Lines: 25

Since the variable 'first' is assigned to 1, the check
"if (truncate && !first)" will always be false.

Thanks to Coverity for spotting this issue.

Signed-off-by: Maxin B. John <maxin.john@gmail.com>
---
diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
index 76b8937..441c1a4 100644
--- a/net/ipv6/mcast.c
+++ b/net/ipv6/mcast.c
@@ -1536,8 +1536,6 @@ static struct sk_buff *add_grec(struct sk_buff *skb, struct ifmcaddr6 *pmc,
 
 		if (AVAILABLE(skb) < sizeof(*psrc) +
 		    first*sizeof(struct mld2_grec)) {
-			if (truncate && !first)
-				break;	 /* truncate these */
 			if (pgr)
 				pgr->grec_nsrcs = htons(scount);
 			if (skb)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/