Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758310Ab1ENPwi (ORCPT ); Sat, 14 May 2011 11:52:38 -0400 Received: from www.linutronix.de ([62.245.132.108]:54410 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757560Ab1ENPwg (ORCPT ); Sat, 14 May 2011 11:52:36 -0400 Date: Sat, 14 May 2011 17:52:34 +0200 (CEST) From: Thomas Gleixner To: Jonathan Cameron cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] irq: export handle_simple_irq, irq_modify_status, irq_to_desc, irq_alloc_descs and irq_free_descs In-Reply-To: <4DCD50BF.2030308@cam.ac.uk> Message-ID: References: <1304525890-11915-1-git-send-email-jic23@cam.ac.uk> <4DCA5A97.90704@cam.ac.uk> <4DCD3696.3090804@cam.ac.uk> <4DCD50BF.2030308@cam.ac.uk> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1288 Lines: 40 On Fri, 13 May 2011, Jonathan Cameron wrote: > On 05/13/11 16:17, Thomas Gleixner wrote: > > On Fri, 13 May 2011, Jonathan Cameron wrote: > > > >> Hi Thomas. > >> > >> Just a quick request that you give a yes or no to this. > >> > >> Thanks and sorry for repeated pestering! > > > > Sorry for the delay. > > > >>>> /** > >>>> * irq_cpu_online - Invoke all irq_cpu_online functions. > >>>> diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c > >>>> index 2c039c9..5ac14e2 100644 > >>>> --- a/kernel/irq/irqdesc.c > >>>> +++ b/kernel/irq/irqdesc.c > >>>> @@ -110,6 +110,7 @@ struct irq_desc *irq_to_desc(unsigned int irq) > >>>> { > >>>> return radix_tree_lookup(&irq_desc_tree, irq); > >>>> } > >>>> +EXPORT_SYMBOL_GPL(irq_to_desc); > > > > I'm fine with that, just this one makes me a bit wary. > It does feel a little fishy. For reference of others - it's required as > generic_handle_irq is inline in the irqdesc.h and uses it. I know and there is no real reason why generic_handle_irq needs to be inline. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/