DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type:content-transfer-encoding;
        b=FgAJtmlVNlluUVypf64OZn0MlPMksdywGMpmNRgONqRZzPH95J8gHuYaO3M31mGRLD
         X4/vJb4OkArHlzCuzy7wzEWDVzDfudy/Ac/W0olMQqc96chSlq+GcLaVJLudBjVEmHoQ
         BvRZDuat4nKil83fOAZJ0Gn/zHx6jG3eDra9o=
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.00.1105040522250.4503@localhost6.localdomain6>
References: <alpine.DEB.2.00.1105040522250.4503@localhost6.localdomain6>
From: Jim Cromie <jim.cromie@gmail.com>
Date: Sat, 14 May 2011 13:41:55 -0600
Message-ID: <BANLkTikzWDa8SbULd45_ReDzweR6pnZsQA@mail.gmail.com>
Subject: Re: [PATCH] PC8736X: Correct dev_dbg() message showing major number.
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1050
Lines: 30

On Wed, May 4, 2011 at 3:26 AM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
>
> Currently, the debugging info is incorrect, as a successful call to
> either register_chrdev_region() or alloc_chrdev_region() returns
> simply zero, which appears to be what the following code would print.
> Skip the checking, just print the value of "major", which should be
> correct.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---


NAK.  'dynamic' is not always correct

> + ? ? ? dev_dbg(&pdev->dev, "got dynamic major %d\n", major);

Ive got patches to replace register|alloc _chrdev_region
which may require merge conflict resolution.
Id prefer to hold off til theyre reviewed, accepted.

Actually, shouldnt conflict - rc<0 code is in between.
If you want to rework it, I'll ack it.

thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/