Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755170Ab1ENWOr (ORCPT ); Sat, 14 May 2011 18:14:47 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:48865 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754790Ab1ENWOq (ORCPT ); Sat, 14 May 2011 18:14:46 -0400 Date: Sat, 14 May 2011 15:14:46 -0700 From: Mark Brown To: Arnd Bergmann Cc: Subhasish Ghosh , "Nori, Sekhar" , linux-arm-kernel@lists.infradead.org, davinci-linux-open-source@linux.davincidsp.com, sachi@mistralsolutions.com, Samuel Ortiz , open list , "Watkins, Melissa" Subject: Re: [PATCH v4 01/11] mfd: add pruss mfd driver. Message-ID: <20110514221445.GB21792@opensource.wolfsonmicro.com> References: <1303474109-6212-1-git-send-email-subhasish@mistralsolutions.com> <20110514160126.GA2791@opensource.wolfsonmicro.com> <201105142233.53659.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201105142233.53659.arnd@arndb.de> X-Cookie: You have no real enemies. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1250 Lines: 27 On Sat, May 14, 2011 at 10:33:53PM +0200, Arnd Bergmann wrote: > I guess drivers/mfd would be a better place than drivers/misc, but it might not > need to be an mfd driver in the sense that it registers mfd cells. Yes, it might be more sensible to just open code. OTOH mfd_cell is marginally easier to use. > The more important point is to remove the device registration from the board > file. You definitely should not have the cells in the board file, but replacing > them with platform devices in the board file makes it no better. Agreed entirely, it should be something higher level than that. > My whole point has been that you register them from the main pruss driver > based on run-time data instead of compile-time pre-configured stuff in the > board file. I'm not so sure - if the usage is fixed as a result of the pins on the device being wired a CAN bus then it seems reasonable to tell the system about that so it'll stop the user trying to run SPI or something against it at runtime. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/