Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753841Ab1EPCKc (ORCPT ); Sun, 15 May 2011 22:10:32 -0400 Received: from ch1outboundpool.messaging.microsoft.com ([216.32.181.185]:20630 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752382Ab1EPCK3 convert rfc822-to-8bit (ORCPT ); Sun, 15 May 2011 22:10:29 -0400 X-SpamScore: -25 X-BigFish: VS-25(zz9371O4015L542M1432N98dKzz1202hzz8275chz2dh2a8h668h839h62h) X-Spam-TCS-SCL: 1:0 X-Forefront-Antispam-Report: KIP:(null);UIP:(null);IPVD:NLI;H:mail.freescale.net;RD:none;EFVD:NLI From: Hu Mingkai-B21284 To: Lennart Sorensen CC: "linux-kernel@vger.kernel.org" , Grant Likely , Kumar Gala Subject: RE: spi_fsl_spi broken when compiled as module by b36ece832512c1a0afa54ff0a56d63492a1caf08 Thread-Topic: spi_fsl_spi broken when compiled as module by b36ece832512c1a0afa54ff0a56d63492a1caf08 Thread-Index: AQHMD/NmlBRc3temmEW7N4NnUhxzZZSIaR3wgAE4d4CABRpUAA== Date: Mon, 16 May 2011 02:10:25 +0000 Message-ID: <9389EE59E16E9447AFB481039183BCF411AA99@039-SN1MPN1-005.039d.mgd.msft.net> References: <20110511155211.GA21349@caffeine.csclub.uwaterloo.ca> <9389EE59E16E9447AFB481039183BCF4117B10@039-SN1MPN1-005.039d.mgd.msft.net> <20110512151113.GE21345@caffeine.csclub.uwaterloo.ca> In-Reply-To: <20110512151113.GE21345@caffeine.csclub.uwaterloo.ca> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.193.20.97] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2927 Lines: 95 Hi len, You can prepare the patch using git tool and send it to the maillist. Also add spi-devel-general@lists.sourceforge.net maillist. Thanks, Mingkai > -----Original Message----- > From: Lennart Sorensen [mailto:lsorense@csclub.uwaterloo.ca] > Sent: Thursday, May 12, 2011 11:11 PM > To: Hu Mingkai-B21284 > Cc: Lennart Sorensen; linux-kernel@vger.kernel.org; Grant Likely; Kumar > Gala > Subject: Re: spi_fsl_spi broken when compiled as module by > b36ece832512c1a0afa54ff0a56d63492a1caf08 > > On Thu, May 12, 2011 at 01:33:55AM +0000, Hu Mingkai-B21284 wrote: > > Please submit a patch to modify it. > > OK. Here it is. > > -- > Len Sorensen > > Add missing exports and module license to allow compiling of spi_fsl_* > drivers as modules again. Originally broken by refactoring of code in > b36ece832512c1a0afa54ff0a56d63492a1caf08. > > diff --git a/drivers/spi/spi_fsl_lib.c b/drivers/spi/spi_fsl_lib.c index > ff59f42..d7efaac 100644 > --- a/drivers/spi/spi_fsl_lib.c > +++ b/drivers/spi/spi_fsl_lib.c > @@ -48,16 +48,23 @@ u32 mpc8xxx_spi_tx_buf_##type(struct mpc8xxx_spi > *mpc8xxx_spi) \ > } > > MPC8XXX_SPI_RX_BUF(u8) > +EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u8); > MPC8XXX_SPI_RX_BUF(u16) > +EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u16); > MPC8XXX_SPI_RX_BUF(u32) > +EXPORT_SYMBOL(mpc8xxx_spi_rx_buf_u32); > MPC8XXX_SPI_TX_BUF(u8) > +EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u8); > MPC8XXX_SPI_TX_BUF(u16) > +EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u16); > MPC8XXX_SPI_TX_BUF(u32) > +EXPORT_SYMBOL(mpc8xxx_spi_tx_buf_u32); > > struct mpc8xxx_spi_probe_info *to_of_pinfo(struct fsl_spi_platform_data > *pdata) { > return container_of(pdata, struct mpc8xxx_spi_probe_info, pdata); } > +EXPORT_SYMBOL(to_of_pinfo); > > void mpc8xxx_spi_work(struct work_struct *work) { @@ -116,6 +123,7 @@ > const char *mpc8xxx_spi_strmode(unsigned int flags) > } > return "CPU"; > } > +EXPORT_SYMBOL(mpc8xxx_spi_strmode); > > int mpc8xxx_spi_probe(struct device *dev, struct resource *mem, > unsigned int irq) > @@ -168,6 +176,7 @@ int mpc8xxx_spi_probe(struct device *dev, struct > resource *mem, > err: > return ret; > } > +EXPORT_SYMBOL(mpc8xxx_spi_probe); > > int __devexit mpc8xxx_spi_remove(struct device *dev) { @@ -188,6 +197,7 > @@ int __devexit mpc8xxx_spi_remove(struct device *dev) > > return 0; > } > +EXPORT_SYMBOL(mpc8xxx_spi_remove); > > int __devinit of_mpc8xxx_spi_probe(struct platform_device *ofdev) { @@ - > 234,3 +244,8 @@ err: > kfree(pinfo); > return ret; > } > +EXPORT_SYMBOL(of_mpc8xxx_spi_probe); > + > +MODULE_AUTHOR("Kumar Gala"); > +MODULE_DESCRIPTION("Freescale SPI/eSPI controller driver library"); > +MODULE_LICENSE("GPL"); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/